On May 20, 2011, at 6:48 AM, Anton Lokhmotov wrote:> Hi Chris, > >> Sorry for dropping this. Can you resend your current patch? Lets just >> start and iterate on the llvm patch first. > Please find the LLVM patch attached.Hi Anton, This looks like a great start, but it needs a lot of testcases showing that these things constant fold, handle conversions correctly, and generally work. Also, there is no code generator support for these. -Chris
Hi Chris,> This looks like a great start, but it needs a lot of testcases showing > that these things constant fold, handle conversions correctly, and > generally work.We believe the added test cases should be sufficient. Please review.> Also, there is no code generator support for these.I was under impression that you argued that only backends for targets supporting the half type natively should implement code generation for half (http://lists.cs.uiuc.edu/pipermail/llvmdev/2011-March/038839.html). AFAIK, there are no such open-source backends at the moment? Best regards, Anton. -------------- next part -------------- A non-text attachment was scrubbed... Name: arm-half.patch Type: application/octet-stream Size: 16051 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110623/e42cafc2/attachment.obj>
Hi Chris, We have updated the half patch for TOT. Could you review please? Many thanks, Anton.> -----Original Message----- > From: Anton Lokhmotov [mailto:Anton.Lokhmotov at arm.com] > Sent: 23 June 2011 12:51 > To: 'Chris Lattner' > Cc: llvmdev at cs.uiuc.edu > Subject: RE: [LLVMdev] [PATCH] OpenCL half support > > Hi Chris, > > > This looks like a great start, but it needs a lot of testcases > showing > > that these things constant fold, handle conversions correctly, and > > generally work. > We believe the added test cases should be sufficient. Please review. > > > Also, there is no code generator support for these. > I was under impression that you argued that only backends for targets > supporting the half type natively should implement code generation for > half (http://lists.cs.uiuc.edu/pipermail/llvmdev/2011- > March/038839.html). AFAIK, there are no such open-source backends at > the moment? > > Best regards, > Anton.-------------- next part -------------- A non-text attachment was scrubbed... Name: arm-half.patch Type: application/octet-stream Size: 16623 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110713/7db6601b/attachment.obj>