On Monday 01 March 2010 20:34:07 Dan Gohman wrote:> Do you have a fix for the blackfin codegen? That would be a great > way to motivate this patch.I'm not following you. Why does a fix for a bug have anything to do with a patch that catches bugs?> Otherwise, at a glance, it appears you fixed the issues I raised, > so this is fine, if it catches real bugs.Oh, it catches real bugs. I'm still trying to determine what in our code causes it to trip elsewhere. But regardless, it's a defensive programming technique and to me that's valuable even if it never finds a bug. -Dave
On Mar 2, 2010, at 8:58 AM, David Greene wrote:> On Monday 01 March 2010 20:34:07 Dan Gohman wrote: >> Do you have a fix for the blackfin codegen? That would be a great >> way to motivate this patch. > > I'm not following you. Why does a fix for a bug have anything to do > with a patch that catches bugs?It helps people understand what's being checked. On an unrelated topic, the patch works by replacing the normal use list with a std::list. To be really complete, it should leave the normal use list in place, so that it the normal use list code continues to be tested in XDEBUG builds. A parallel std::list could be maintained for consistency checking. Dan
On Wednesday 03 March 2010 15:12:01 Dan Gohman wrote:> > I'm not following you. Why does a fix for a bug have anything to do > > with a patch that catches bugs? > > It helps people understand what's being checked.I can add some commentary about that. That's a good idea, actually. :)> On an unrelated topic, the patch works by replacing the normal use > list with a std::list. To be really complete, it should leave the > normal use list in place, so that it the normal use list code > continues to be tested in XDEBUG builds. A parallel std::list > could be maintained for consistency checking.Hmm, I can see value there. It would require defining a use_iterator to hold both an "original use_iterator" and a std::list<>::iterator and we'd have to make all of the operations update two parallel lists. Does that sound like the right approach to you? -Dave