On Dec 15, 2009, at 2:53 PM, David Greene wrote:> On Tuesday 15 December 2009 15:21, David Greene wrote: > >> Please review and let me know what needs to change before I start >> merging stuff in. > > I left in quite a few unnecessary headers from previous incarnations > (streambuf, etc.). I will fix those. Please comment on the rest.Hi David, Please send complete and minimal patches to avoid wasting reviewer's time, -Chris
On Tuesday 15 December 2009 20:11, Chris Lattner wrote:> Please send complete and minimal patches to avoid wasting reviewer's > time,What do you want, complete or minimal? I don't want to pre-send 50 or so patches (one per source file) that simply change errs() to dbgs(). Thus I thought I would send a patch representative of what will happen. What, specifically, do you want reviewed before I start checking in? I'll be happy to prepare a patch that shows just that. -Dave
On Dec 15, 2009, at 6:33 PM, David Greene wrote:> On Tuesday 15 December 2009 20:11, Chris Lattner wrote: > >> Please send complete and minimal patches to avoid wasting reviewer's >> time, > > What do you want, complete or minimal? I don't want to pre-send 50 > or so patches (one per source file) that simply change errs() to dbgs(). > Thus I thought I would send a patch representative of what will happen. > > What, specifically, do you want reviewed before I start checking in? > I'll be happy to prepare a patch that shows just that.I want a patch that does one thing (e.g. implements dbgs(), optionally switches clients to use it) that is complete enough that I can apply it to the tree and test it if I so choose. It should not have unrelated stuff in it (like other unrelated work). -Chris