>I just sent a reply to Razvan with 3 patches that I think should be merged >into the release branch. I want to keep it somewhat in sync with mainline. >Can you try applying those 3 patches and let me know if it builds for you >and what version of MSVC you have?It doesn't build. first problem is patch 51098 that adds lib\VMCore\Use.cpp and lib\Transforms\Utils\UnrollLoop.cpp neither of which seem to exist in the release_23 branch another problem is patch 51237 which among other things renames lib\Transforms\Scalar\SimplifyCFG.cpp to lib\Transforms\Scalar\SimplifyCFGPass.cpp however the removal of lib\Transforms\Ipo\SimplifyLibCalls.cpp is necessary, so it won't build without this patch either. I didn't have to apply patch 51323 to get things to build -- but the patch seems correct and it builds OK with it applied FYI I'm using Visual Studio 2005 Professional Edition (not Express). m. PS. The proposed fix (by heisenbug) to the warnings from the operator new in User.h doesn't work at all.
Ok, thanks. So it seems like we have to deviate from mainline a bit. I can apply the patch that you proposed in your earlier mail. Sound ok? I just need someone to verify that it works with 2008 so that everyone is happy. -Tanya On Wed, 21 May 2008 morten at hue.no wrote:> >> I just sent a reply to Razvan with 3 patches that I think should be merged >> into the release branch. I want to keep it somewhat in sync with mainline. >> Can you try applying those 3 patches and let me know if it builds for you >> and what version of MSVC you have? > > It doesn't build. > > first problem is patch 51098 that adds lib\VMCore\Use.cpp and lib\Transforms\Utils\UnrollLoop.cpp neither of which seem to exist in the release_23 branch > > another problem is patch 51237 which among other things renames lib\Transforms\Scalar\SimplifyCFG.cpp > to lib\Transforms\Scalar\SimplifyCFGPass.cpp > however the removal of lib\Transforms\Ipo\SimplifyLibCalls.cpp is necessary, so it won't build without this patch either. > > I didn't have to apply patch 51323 to get things to build -- but the patch seems correct and it builds OK with it applied > > FYI I'm using Visual Studio 2005 Professional Edition (not Express). > > m. > > PS. The proposed fix (by heisenbug) to the warnings from the operator new in User.h doesn't work at all. > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >
On May 21, 11:21 pm, mor... at hue.no wrote: [snip]> > FYI I'm using Visual Studio 2005 Professional Edition (not Express). > > m. > > PS. The proposed fix (by heisenbug) to the warnings from the operator new in User.h doesn't work at all.Hmmm, this is really unfortunate. http://www.glenmccl.com/tip_025.htm confirms the given recipe. By "doesn't work at all" you mean that the warnings still appear, or do you get errors? Thanks for helping to get this problem resolved, Morten! Cheers, Gabor
Errrrr, please make that
void operator delete(void*, size_t) {}
The mainline changed it in the meantime (size_t --> unsigned).
Sorry for the confusion :-/
Cheers,
Gabor
On May 22, 12:39 am, heisenbug <ggr... at gmail.com>
wrote:> On May 21, 11:21 pm, mor... at hue.no wrote:
>
> [snip]
>
>
>
> > FYI I'm using Visual Studio 2005 Professional Edition (not
Express).
>
> > m.
>
> > PS. The proposed fix (by heisenbug) to the warnings from the operator
new in User.h doesn't work at all.
>
> Hmmm, this is really unfortunate.http://www.glenmccl.com/tip_025.htm
> confirms the given recipe.
> By "doesn't work at all" you mean that the warnings still
appear, or
> do you get errors?
>
> Thanks for helping to get this problem resolved, Morten!
>
> Cheers,
>
> Gabor
>
> _______________________________________________
> LLVM Developers mailing list
> LLVM... at cs.uiuc.edu
http://llvm.cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Tanya M. Lattner wrote:> Ok, thanks. So it seems like we have to deviate from mainline a bit. I can > apply the patch that you proposed in your earlier mail. Sound ok?Sounds good to me -- I reviewed the patch a bit, and a lot of it is just noise because Visual Studio decided to reorder the definition of the debug and release configurations. I attached a minimal patch to this mail.> I just need someone to verify that it works with 2008 so that everyone is > happy.It can't get more broken than it is now, as it doesn't build at all with either 2005 or 2008... m. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: release_23_vs2005.patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080522/80e9ac89/attachment.ksh>