Tanya M. Lattner
2008-May-13 21:18 UTC
[LLVMdev] -loop-deletion commandline option inconsistent?
>> the newly added LoopDeletion pass uses loop-deletion as it's name (and thus >> commandline option for opt). Looking at the other loop passes (loop-rotate, >> loop-unroll, loop-reduce), perhaps loop-delete would be a better name? > No opinions on this? If this is ever going to be changed, it's probably a good > idea to do it before the 2.3 release, not after...2.3 has already branched and loop delete is not on by default. This can be changed after. -Tanya> > Gr. > > Matthijs >
Matthijs Kooijman
2008-May-14 07:32 UTC
[LLVMdev] -loop-deletion commandline option inconsistent?
Hi Tanya,> 2.3 has already branched and loop delete is not on by default. This can be > changed after.Doesn't that just mean that it's not part of std-compile-opts, and thus the only way to use it is the (inconsistent) -loop-deletion commandline option? I'm just saying that it might be better not to change a commandline option between releases if it's not needed. I'll stop nagging now, this is your call after all :-) Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080514/5bc5e763/attachment.sig>
Tanya M. Lattner
2008-May-14 17:08 UTC
[LLVMdev] -loop-deletion commandline option inconsistent?
>> 2.3 has already branched and loop delete is not on by default. This can be >> changed after. > Doesn't that just mean that it's not part of std-compile-opts, and thus the > only way to use it is the (inconsistent) -loop-deletion commandline option?Correct.> I'm just saying that it might be better not to change a commandline option > between releases if it's not needed. > > I'll stop nagging now, this is your call after all :-)I'll verify with Chris on this. Its obviously low risk, and I have 3 patches going into the next pre-release, so it may go in. Traditionally, we try to keep the number of patches applied to the release branch small and limited to regression fixes only. loop-deletion is really a new feature, which is why I said it wasn't critical to go into 2.3. Thanks, -Tanya
Seemingly Similar Threads
- [LLVMdev] -loop-deletion commandline option inconsistent?
- [LLVMdev] -loop-deletion commandline option inconsistent?
- [LLVMdev] -loop-deletion commandline option inconsistent?
- [LLVMdev] [PATCH] Internalize improvements
- Inconsistencies between ExtLinux and IsoLinux