Hi all, I was looking at the StructRetPromotion pass this morning and noticed it doesn't look at a function's linkage at all. Since it changes the signature of the function, I would say it should only change internal functions, like ArgumentPromotion does for example. Is there some implicit check I'm missing, or should an explicit check really be added? Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080508/0d7f3347/attachment.sig>
> I was looking at the StructRetPromotion pass this morning and noticed it > doesn't look at a function's linkage at all. Since it changes the signature of > the function, I would say it should only change internal functions, like > ArgumentPromotion does for example. > > Is there some implicit check I'm missing, or should an explicit check really > be added?It looks like the check was forgotten. Ciao, Duncan.
On May 8, 2008, at 2:53 AM, Matthijs Kooijman wrote:> Hi all, > > I was looking at the StructRetPromotion pass this morning and > noticed it > doesn't look at a function's linkage at all. Since it changes the > signature of > the function, I would say it should only change internal functions, > like > ArgumentPromotion does for example. > > Is there some implicit check I'm missing, or should an explicit > check really > be added?I added the missing check. - Devang