Hi, I was evaluating all transformation passes and noticed a few things. In particular, I found three passes in the documentation that I can't seem to find any code for. Where these removed? Lower GC intrinsics, for GCless code generators (-lowergc) Correlated Expression Elimination (-cee) Lower select instructions to branches (-lowerselect) Additionally, I found the following passes for which no documentation was present: createGVExtractionPass() createStructRetPromotionPass() createStripDeadPrototypesPass() createJumpThreadingPass() createMemCpyOptPass() createLoopDeletionPass() createCodeGenPreparePass() From what I saw in Passes.html, the passes documentation is not generated automatically? What's the policy on updating this documentation? Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080507/ae0f631d/attachment.sig>
On 2008-05-07, at 08:42, Matthijs Kooijman wrote:> I was evaluating all transformation passes and noticed a few things. > In particular, I found three passes in the documentation that I > can't seem to find any code for. Where these removed? > Lower GC intrinsics, for GCless code generators (-lowergc)Yes; this pass at least has been removed.> Correlated Expression Elimination (-cee) > Lower select instructions to branches (-lowerselect) > > Additionally, I found the following passes for which no > documentation was present: > createGVExtractionPass() > createStructRetPromotionPass() > createStripDeadPrototypesPass() > createJumpThreadingPass() > createMemCpyOptPass() > createLoopDeletionPass() > createCodeGenPreparePass() > > From what I saw in Passes.html, the passes documentation is not > generated automatically?It is not, although I think there's a 'one-liner' to help with updating it.> What's the policy on updating this documentation?It hasn't been updated since I completed it several months ago, AFAIK. Please submit a patch if you like. — Gordon
On May 7, 2008, at 7:04 AM, Gordon Henriksen wrote:> On 2008-05-07, at 08:42, Matthijs Kooijman wrote: > >> I was evaluating all transformation passes and noticed a few things. >> In particular, I found three passes in the documentation that I >> can't seem to find any code for. Where these removed? >> Lower GC intrinsics, for GCless code generators (-lowergc) > > Yes; this pass at least has been removed. > >> Correlated Expression Elimination (-cee) >> Lower select instructions to branches (-lowerselect)These two were also removed. Dan
Hi all, I've attached two patches. The first, pass-comments.diff adds or improves the file comments for a number of passes. This patch is slightly interesting. The second, pass-doc.diff is mostly a yank-put job and updates Passes.html as follows. I've removed the following passes from the documentation: Lower GC intrinsics, for GCless code generators (-lowergc) Correlated Expression Elimination (-cee) Lower select instructions to branches (-lowerselect) lowers packed operations to operations on smaller packed datatypes (-lower-packed) (I didn't report the last one in my initial posting, though I had noticed it was missing). I've added the following passes to the documentation:> createStructRetPromotionPass() > createStripDeadPrototypesPass() > createJumpThreadingPass() > createMemCpyOptPass() > createLoopDeletionPass() > createCodeGenPreparePass()I've left out the Global Value Extraction Pass, since that doesn't seem to be a full pass in itself (no RegisterPass for example). I've also pulled Passes.html through the w3 validator, only to discover some errors of my own :-) Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: pass-comments.diff Type: text/x-diff Size: 6010 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080508/0fe8f758/attachment.diff> -------------- next part -------------- A non-text attachment was scrubbed... Name: pass-doc.diff Type: text/x-diff Size: 12529 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080508/0fe8f758/attachment-0001.diff> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080508/0fe8f758/attachment.sig>
On May 8, 2008, at 05:50, Matthijs Kooijman wrote:> I've attached two patches. The first, pass-comments.diff adds or > improves the file comments for a number of passes. This patch is > slightly interesting. The second, pass-doc.diff is mostly a yank-put > job and updates Passes.html as follows.Thanks, applied! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080505/062161.html The passes for which you updated the comments are primarily written by: Chris: lib/Transforms/IPO/StripDeadPrototypes.cpp Devang: lib/Transforms/IPO/StructRetPromotion.cpp Chris: lib/Transforms/Scalar/CodeGenPrepare.cpp Chris/Evan: lib/Transforms/Scalar/JumpThreading.cpp Chris: lib/Transforms/Scalar/LoopDeletion.cpp Who should probably review the added comments for accuracy. — Gordon