llvm dev - May 2008 - [LLVMdev] LoopInfo::isAnalysis() unused?

Hi,

I was looking at the LoopInfo Analysis pass as an example, and found it
defined the isAnalysis() method to return true. I assumed the method was
overriden from some superclass (Pass, probably) and present in all analysis
passes.

However, a better look turns out that the method isn't really used anywhere.
PassInfo does define the same method which is used, but PassInfo is not a
superclass of LoopInfo. AFAICS, LoopInfo::isAnalysis
(include/llvm/Analysis/LoopInfo.h:924) is unused and can/should be removed?

Removing the method doesn't break compilation for me.

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080505/e9212463/attachment.sig>

On May 5, 2008, at 9:12 AM, Matthijs Kooijman wrote:
> Hi,
>
> I was looking at the LoopInfo Analysis pass as an example, and found  
> it
> defined the isAnalysis() method to return true. I assumed the method  
> was
> overriden from some superclass (Pass, probably) and present in all  
> analysis
> passes.
>
> However, a better look turns out that the method isn't really used  
> anywhere.
> PassInfo does define the same method which is used, but PassInfo is  
> not a
> superclass of LoopInfo. AFAICS, LoopInfo::isAnalysis
> (include/llvm/Analysis/LoopInfo.h:924) is unused and can/should be  
> removed?
Yes. I removed it. Thanks!
-
Devang