llvm dev - Feb 2008 - [LLVMdev] [PATCH] Add an assert to make sure PATypeHolder doesn't get a null pointer.

Hello,

I ran into an issue with the ocaml bindings where PATypeHolder was getting a
null pointer, which eventually caused a segfault. This patch copies what
PATypeHandle does and adds the assert in the PATypeHolder::addRef method.

Also, I'm using git's gateway to subversion to track llvm and send this
patch. The patch applies fine according to my tests, but if there are any 
problems, I'll find a better way to do this.

-e

---
 include/llvm/Type.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: b0fec310cc5450e1b9802a28f02da9fa2a35e02d.diff
Type: text/x-patch
Size: 372 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080225/dcc614ab/attachment.bin>

On Mon, 25 Feb 2008, Erick Tryzelaar wrote:
> I ran into an issue with the ocaml bindings where PATypeHolder was getting
a
> null pointer, which eventually caused a segfault. This patch copies what
> PATypeHandle does and adds the assert in the PATypeHolder::addRef method.
>
> Also, I'm using git's gateway to subversion to track llvm and send
this
> patch. The patch applies fine according to my tests, but if there are any
> problems, I'll find a better way to do this.
Looks great to me, applied, thanks!
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080225/058766.html

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/