Hi, all. I'm working on adding support for the CPATH, C_INCLUDE_PATH, etc environment variables in clang. They hold lists of include directories, formatted like the PATH environment variable: on Windows the separator is a semicolon, on Unix the separator is a colon. It makes sense to me to have the llvm System library export the separator, since it already knows what it is. Doing this also allowed me to push the getPathList function up into the shared System/Path code. (I considered exporting the getPathList function itself, but the "include" environment variables treat empty entries in a special way.) I would appreciate someone merging this patch if there are no objections to it. Thanks, Sam Bishop -------------- next part -------------- A non-text attachment was scrubbed... Name: make-path-separator-public.patch Type: text/x-patch Size: 3483 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080225/e1ad0da4/attachment.bin>
On Feb 25, 2008, at 10:14 AM, Sam Bishop wrote:> Hi, all. > > I'm working on adding support for the CPATH, C_INCLUDE_PATH, etc > environment > variables in clang. They hold lists of include directories, > formatted like > the PATH environment variable: on Windows the separator is a > semicolon, on > Unix the separator is a colon. It makes sense to me to have the > llvm System > library export the separator, since it already knows what it is. > > Doing this also allowed me to push the getPathList function up into > the > shared System/Path code. (I considered exporting the getPathList > function > itself, but the "include" environment variables treat empty entries > in a > special way.)Looks great to me, thanks! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080225/058871.html -Chris