llvm dev - Dec 2007 - [LLVMdev] PATCH: X86 calling convention cleanup

The four X86 calling convention implementations in X86ISelLowering.cpp  
contain several hundred lines of duplicated code. This patch refines  
the copies so that diff reveals refactoring opportunities instead of  
noise. Okay to commit?

(My goal is to introduce a crazy new ABI.)

— Gordon


-------------- next part --------------
A non-text attachment was scrubbed...
Name: cconv.patch
Type: application/octet-stream
Size: 22971 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20071231/4368eace/attachment.obj>
-------------- next part --------------

Yes, looks good to me.

Thanks for signing up to do the refactoring! I know this code can use  
a good scrubbing.

Evan

On Dec 30, 2007, at 11:25 PM, Gordon Henriksen wrote:
> The four X86 calling convention implementations in  
> X86ISelLowering.cpp contain several hundred lines of duplicated  
> code. This patch refines the copies so that diff reveals refactoring  
> opportunities instead of noise. Okay to commit?
>
> (My goal is to introduce a crazy new ABI.)
>
> — Gordon
>
>
> <cconv.patch>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev