Rafael Espíndola
2006-Dec-09 22:25 UTC
[LLVMdev] [patch] move ExtWeakSymbols to AsmPrinter
The attached patch moves the ExtWeakSymbols to the AsmPrinter class and the code that emits the ".weak" directives to AsmPrinter::doFinalization. This is just code factoring. No functionality changes. Best Regards, Rafael -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 5387 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061209/397cc576/attachment.bin>
On Sat, 9 Dec 2006, [UTF-8] Rafael Esp?ndola wrote:> The attached patch moves the ExtWeakSymbols to the AsmPrinter class > and the code that emits the ".weak" directives to > AsmPrinter::doFinalization. > > This is just code factoring. No functionality changes.Looks good, one request though: if practical, it would be nice to switch this to be set<GlobalValue*> instead of set<std::string>. -Chris -- http://nondot.org/sabre/ http://llvm.org/
Rafael Espíndola
2006-Dec-11 13:03 UTC
[LLVMdev] [patch] move ExtWeakSymbols to AsmPrinter
> Looks good, one request though: if practical, it would be nice to switch > this to be set<GlobalValue*> instead of set<std::string>.Attached> -ChrisRafael -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 7646 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061211/5e5c8771/attachment.bin>