llvm dev - Aug 2006 - [LLVMdev] Problem with stock llvmc configuration for C

Hi,

Op 14-aug-06, om 09:29 heeft Reid Spencer het volgende geschreven:
>
>> Apparently, %llvmgccdir% and %llvmcc1% are not recognized as a useful
>> variable by the llvmc configuration parser.
>
> Actually, they are. See tools/llvmc/ConfigurationDriver.cpp around  
> line
> 304. Also, they are recognized by the lexer. Its more likely that when
> you configured LLVM you didn't provide the --with-llvmgccdir= option.
They're indeed mentioned, but somehow they were not added to the  
switch-statements in the corresponding parsing functions for the  
various configuration options. I attached a patch in which this is  
resolved, as well as two other bugs:
  * an off-by-one error in a loop copying a command's arguments into  
an array (first argument was dismissed; garbage added at the end);
  * %...%'s in a command name were not substituted, whereas they were  
in the command's arguments.

The patch solved things for me, but it's not perfect yet.
>
>> I found out in tools/
>> llvmc/Configuration.cpp that two other library-related variables
>> exist, notably %libdir% and %libs%, but it's not clear what they
do.
>
> %libdir% expands to LLVM_LIBDIR which is the installation location of
> LLVM libraries.
> %libs% expands to the list of system (non-LLVM) libraries needed to  
> link
> with LLVM.
OK.

Kind regards,

Bram Adams
GH-SEL, INTEC, Ghent University (Belgium)

PS: I recently saw an email passing by in which someone else was  
talking about a patch for llvmc. Has that one been committed yet?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.llvmc-1.8
Type: application/octet-stream
Size: 4483 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20060816/9fe380ba/attachment.obj>

Hi Bram,

Patches all looked good. I've committed them unchanged. Thanks for the
contribution!

Patches here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036798.html

Reid.

On Wed, 2006-08-16 at 21:57 +0200, Bram Adams wrote:
> Hi,
> 
> Op 14-aug-06, om 09:29 heeft Reid Spencer het volgende geschreven:
> 
> >
> >> Apparently, %llvmgccdir% and %llvmcc1% are not recognized as a
useful
> >> variable by the llvmc configuration parser.
> >
> > Actually, they are. See tools/llvmc/ConfigurationDriver.cpp around  
> > line
> > 304. Also, they are recognized by the lexer. Its more likely that when
> > you configured LLVM you didn't provide the --with-llvmgccdir=
option.
> 
> They're indeed mentioned, but somehow they were not added to the  
> switch-statements in the corresponding parsing functions for the  
> various configuration options. I attached a patch in which this is  
> resolved, as well as two other bugs:
>   * an off-by-one error in a loop copying a command's arguments into  
> an array (first argument was dismissed; garbage added at the end);
>   * %...%'s in a command name were not substituted, whereas they were  
> in the command's arguments.
> 
> The patch solved things for me, but it's not perfect yet.
> 
> >
> >> I found out in tools/
> >> llvmc/Configuration.cpp that two other library-related variables
> >> exist, notably %libdir% and %libs%, but it's not clear what
they do.
> >
> > %libdir% expands to LLVM_LIBDIR which is the installation location of
> > LLVM libraries.
> > %libs% expands to the list of system (non-LLVM) libraries needed to  
> > link
> > with LLVM.
> 
> OK.
> 
> Kind regards,
> 
> Bram Adams
> GH-SEL, INTEC, Ghent University (Belgium)
> 
> PS: I recently saw an email passing by in which someone else was  
> talking about a patch for llvmc. Has that one been committed yet?
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Bram Adams wrote:
> Hi,
> 
> Op 14-aug-06, om 09:29 heeft Reid Spencer het volgende geschreven:
> 
>>
>>> Apparently, %llvmgccdir% and %llvmcc1% are not recognized as a
useful
>>> variable by the llvmc configuration parser.
>>
>>
>> Actually, they are. See tools/llvmc/ConfigurationDriver.cpp around 
line
>> 304. Also, they are recognized by the lexer. Its more likely that when
>> you configured LLVM you didn't provide the --with-llvmgccdir=
option.
> 
> 
> They're indeed mentioned, but somehow they were not added to the 
> switch-statements in the corresponding parsing functions for the 
> various configuration options. I attached a patch in which this is 
> resolved, as well as two other bugs:
>  * an off-by-one error in a loop copying a command's arguments into  an
> array (first argument was dismissed; garbage added at the end);
>  * %...%'s in a command name were not substituted, whereas they were 
in
> the command's arguments.
> 
> The patch solved things for me, but it's not perfect yet.
Damn. And I was testing my version of the same patch... So for, IWFM
with one small problem: with the gcc 4.0 frontend, "-emit-llvm" needs
to
be added to all of the translator.command lines. Not entirely sure how
to conditionalize that in the configuration files.


-scooter

On Thu, 2006-08-17 at 08:55 -0700, Scott Michel wrote:
> Regarding llvmc there is one small problem: with the gcc 4.0 frontend, 
> "-emit-llvm" needs to be added to all of the translator.command
lines.
> Not entirely sure how to conditionalize that in the configuration files.
Hi Scott,

What is needed is a complete overhaul of the configuration mechanism. We
have plans to generalize it and make it possible have several of the
standard configurations "built in" to llvmc while still allowing
others
to be loaded from shared objects or read from files. For further
details, please see:

http://llvm.org/bugs/show_bug.cgi?id=686 

Reid.