I missed two files from the LLVM source code proper. These need reviewing and
commiting. They are trivial changes that should not influence any other builds.
Basically these functions are missing a return statement which Visual Studio
2005 Beta flags as an error rather than as a warning. I have put in dummy
constructors in return statements to allow CodeGen and Target libraries to
build.
The files :-
\llvm\lib\codegen\selectiondag\selectiondagisel.cpp
llvm::TargetLowering::LowerVAStart
llvm::TargetLowering::LowerVAArgNext
llvm::TargetLowering::LowerOperation
\llvm\lib\target\targetframeinfo.cpp
llvm::TargetFrameInfo::adjustAlignment
llvm::TargetFrameInfo::getIncomingArgOffset
llvm::TargetFrameInfo::getOutgoingArgOffset
llvm::TargetFrameInfo::getFirstAutomaticVarOffset
llvm::TargetFrameInfo::getRegSpillAreaOffset
llvm::TargetFrameInfo::getTmpAreaOffset
llvm::TargetFrameInfo::getDynamicAreaOffset
Note I have not commited anything to CVS.
Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050217/42046651/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SelectionDAGISel.cpp
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050217/42046651/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: TargetFrameInfo.cpp
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050217/42046651/attachment-0001.ksh>
On Thu, Feb 17, 2005 at 08:41:41PM -0000, Aaron Gray wrote:> I missed two files from the LLVM source code proper. These need > reviewing and commiting. They are trivial changes that should not > influence any other builds. Basically these functions are missing a > return statement which Visual Studio 2005 Beta flags as an error > rather than as a warning. I have put in dummy constructors in return > statements to allow CodeGen and Target libraries to build. > > The files :- > > \llvm\lib\codegen\selectiondag\selectiondagisel.cpp > \llvm\lib\target\targetframeinfo.cppThanks for the patches! Commits here: http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050214/024164.html http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050214/024165.html -- Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu
>> I missed two files from the LLVM source code proper. These need >> reviewing and commiting. They are trivial changes that should not >> influence any other builds. Basically these functions are missing a >> return statement which Visual Studio 2005 Beta flags as an error >> rather than as a warning. I have put in dummy constructors in return >> statements to allow CodeGen and Target libraries to build. >> >> The files :- >> >> \llvm\lib\codegen\selectiondag\selectiondagisel.cpp >> \llvm\lib\target\targetframeinfo.cpp > > Thanks for the patches! > > Commits here: > > http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050214/024164.html > http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050214/024165.htmlThank you. Hopefully someone will be able to test the main llvm-VS2005 patch soon. Cheers, Aaron