llvm dev - Feb 2005 - [LLVMdev] Add ability for external projects use for build installed version LLVM [PATCH]

>> Also I have in Makefile.rules (but not include in patch) some 
>> modification for simplify used common Makefile.rules in LLVM projects
and
>> non-LLVM project (guarding some LLVM specific parts by ifdef 
>> LLVM_OBJ_ROOT/LLVM_SRC_ROOT vars).
>
> I'm not sure about this, perhaps Reid would like to comment?
>
Patch attached.

This patch with header installation patch ( 
http://mail.cs.uiuc.edu/pipermail/llvmdev/2005-February/003300.html )
let external project (I am test it at my YAFL frontend for LLVM) build using 
installed LLVM version instead using LLVM obj/src dirs.

After patch applying:

If LLVM_SRC_ROOT/LLVM_OBJ_ROOT variables set
project use for build LLVM object/source dir (current behavior)
or else if LLVM_ROOT set
project use for build installed LLVM dir
or else
project can use only LLVM tools in PATHs if installed LLVM dir added to PATH

Also i remove LLVMExmplDir (i not found any it uses in llvm, llvm-java, 
llvm-test CVS modules)
And remove redundent line (as i think):
.PRECIOUS: $(LLVMLibDir)/.dir $(LLVMToolDir)/.dir $(LLVMExmplDir)/.dir

Any comments?

Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.rules.patch
Type: application/octet-stream
Size: 6145 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050207/706e6954/attachment.obj>

On Mon, 7 Feb 2005, Vladimir Merzliakov wrote:
>>> Also I have in Makefile.rules (but not include in patch) some
modification
>>> for simplify used common Makefile.rules in LLVM projects and
non-LLVM
>>> project (guarding some LLVM specific parts by ifdef 
>>> LLVM_OBJ_ROOT/LLVM_SRC_ROOT vars).
>> 
>> I'm not sure about this, perhaps Reid would like to comment?
>> 
> Patch attached.
>
> This patch with header installation patch ( 
> http://mail.cs.uiuc.edu/pipermail/llvmdev/2005-February/003300.html )
> let external project (I am test it at my YAFL frontend for LLVM) build
using
> installed LLVM version instead using LLVM obj/src dirs.
I think the patch looks basically sane.  The one wierd thing I notice is 
the replacement of mklib with libtool.

However, this is definitely something Reid should review.  I think he's 
currently out of town but will be back next week.

-Chris

-- 
http://nondot.org/sabre/
http://llvm.cs.uiuc.edu/

>> Patch attached.
>>
>> This patch with header installation patch ( 
>> http://mail.cs.uiuc.edu/pipermail/llvmdev/2005-February/003300.html )
>> let external project (I am test it at my YAFL frontend for LLVM) build 
>> using installed LLVM version instead using LLVM obj/src dirs.
>
> I think the patch looks basically sane.  The one wierd thing I notice is 
> the replacement of mklib with libtool.
Ops...  I must be more careful. Updated patch attached.

I use for build libtool "ltmain.sh (GNU libtool) 1.5.10" without
problems.
But I add code to preserve use $(LLVM_OBJ_ROOT)/mklib if LLVM_OBJ_ROOT set
In other cases if $(LLVM_OBJ_ROOT)/mklib using important it installation can 
be added to LLVM/PROJ install process
> However, this is definitely something Reid should review.  I think he's
> currently out of town but will be back next week.
Waiting... :)

Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.rules.patch
Type: application/octet-stream
Size: 6229 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050209/2834c32a/attachment.obj>