llvm dev - Feb 2005 - [LLVMdev] Add ability for external projects use for build installed version LLVM [PATCH]

> Doing it this way
> allows you to re-use the LLVM build system, as opposed to building your
> own set of Makefiles.
I have pre-LLVM projects in C++ with often used at Unix C++ source file 
extention .cc
I modify LLVM build system (original LLVM Makefile.rules already partly 
support .cc extention,
for example, in Sources and FakeSources make vars setup code).

Is attached patch acceptable?

Also I have in Makefile.rules (but not include in patch) some modification 
for simplify used common Makefile.rules in LLVM projects and non-LLVM 
project (guarding some LLVM specific parts by ifdef 
LLVM_OBJ_ROOT/LLVM_SRC_ROOT vars).

Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.rules.patch
Type: application/octet-stream
Size: 4330 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050203/c317d8d4/attachment.obj>

On Thu, 3 Feb 2005, Vladimir Merzliakov wrote:
>> Doing it this way
>> allows you to re-use the LLVM build system, as opposed to building your
>> own set of Makefiles.
> I have pre-LLVM projects in C++ with often used at Unix C++ source file 
> extention .cc
> I modify LLVM build system (original LLVM Makefile.rules already partly 
> support .cc extention,
> for example, in Sources and FakeSources make vars setup code).
>
> Is attached patch acceptable?
Looks great, applied, thanks!
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050131/023931.html
> Also I have in Makefile.rules (but not include in patch) some modification 
> for simplify used common Makefile.rules in LLVM projects and non-LLVM
project
> (guarding some LLVM specific parts by ifdef LLVM_OBJ_ROOT/LLVM_SRC_ROOT 
> vars).
I'm not sure about this, perhaps Reid would like to comment?

-Chris

-- 
http://nondot.org/sabre/
http://llvm.cs.uiuc.edu/

>> Is attached patch acceptable?
>
> Looks great, applied, thanks!
>
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050131/023931.html
Thanks!
>> Also I have in Makefile.rules (but not include in patch) some 
>> modification for simplify used common Makefile.rules in LLVM projects
and
>> non-LLVM project (guarding some LLVM specific parts by ifdef 
>> LLVM_OBJ_ROOT/LLVM_SRC_ROOT vars).
At this moment I am test ability use installed LLVM version to build project 
instead requare have builded LLVM object dir.

And i have problem with installed LLVM include dir.

Makefile.rules install only $(PROJ_SRC_ROOT)/include (including *.in files) 
and ignore headers in $(PROJ_OBJ_ROOT)/include
As result installed LLVM does't have all headers for building external 
projects, for example, llvm/ADT/iterator

Proposed patch attached.

It tested making full LLVM build, install and uninstall.

Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.rules.patch
Type: application/octet-stream
Size: 1418 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050206/5b9c1a5b/attachment.obj>

>> Also I have in Makefile.rules (but not include in patch) some 
>> modification for simplify used common Makefile.rules in LLVM projects
and
>> non-LLVM project (guarding some LLVM specific parts by ifdef 
>> LLVM_OBJ_ROOT/LLVM_SRC_ROOT vars).
>
> I'm not sure about this, perhaps Reid would like to comment?
>
Patch attached.

This patch with header installation patch ( 
http://mail.cs.uiuc.edu/pipermail/llvmdev/2005-February/003300.html )
let external project (I am test it at my YAFL frontend for LLVM) build using 
installed LLVM version instead using LLVM obj/src dirs.

After patch applying:

If LLVM_SRC_ROOT/LLVM_OBJ_ROOT variables set
project use for build LLVM object/source dir (current behavior)
or else if LLVM_ROOT set
project use for build installed LLVM dir
or else
project can use only LLVM tools in PATHs if installed LLVM dir added to PATH

Also i remove LLVMExmplDir (i not found any it uses in llvm, llvm-java, 
llvm-test CVS modules)
And remove redundent line (as i think):
.PRECIOUS: $(LLVMLibDir)/.dir $(LLVMToolDir)/.dir $(LLVMExmplDir)/.dir

Any comments?

Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.rules.patch
Type: application/octet-stream
Size: 6145 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050207/706e6954/attachment.obj>