llvm dev - Dec 2004 - [LLVMdev] Undefined referenceto`llvm::sys::CopyFile(llvm::sys::Path const&, llvm::sys::P

Hi Reid,

The error still exists. However, looking on the function in Win32/Path.cpp:
--------------
void
sys::CopyFile(const sys::Path &Dest, const sys::Path &Src) {
  if (!::CopyFile(Src.c_str(), Dest.c_str(), false))
    ThrowError("Can't copy '" + Src.toString() +
               "' to '" + Dest.toString() +
"'");
}
--------------

I notice, that the function is living in the sys namespace. Shouldn't it 
live in the Path class instead? A copy-past to fast ;-)


Henrik.

_________________________________________________________________
Log p� MSN Messenger direkte fra nettet  http://webmessenger.msn.com/

Hi Reid,

Looking closer at the build process, I find that Path.cpp doesn't get 
compiled, even if it is a newer version than its *.o file. That's probaly 
the reason the error still exists. I'm to tired to think, but I'll look 
closer at it tomorrow.

Merry Christmas
Henrik.


----Original Message Follows----
From: "Henrik Bach" <henrik_bach_llvm at hotmail.com>
Reply-To: LLVM Developers Mailing List <llvmdev at cs.uiuc.edu>
To: llvmdev at cs.uiuc.edu
Subject: Re: [LLVMdev] 
Undefinedreferenceto`llvm::sys::CopyFile(llvm::sys::Path const&, 
llvm::sys::P
Date: Fri, 24 Dec 2004 00:48:26 +0100

Hi Reid,

The error still exists. However, looking on the function in Win32/Path.cpp:
--------------
void
sys::CopyFile(const sys::Path &Dest, const sys::Path &Src) {
  if (!::CopyFile(Src.c_str(), Dest.c_str(), false))
    ThrowError("Can't copy '" + Src.toString() +
               "' to '" + Dest.toString() +
"'");
}
--------------

I notice, that the function is living in the sys namespace. Shouldn't it 
live in the Path class instead? A copy-past to fast ;-)


Henrik.

_________________________________________________________________
Log p� MSN Messenger direkte fra nettet  http://webmessenger.msn.com/

_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev

_________________________________________________________________
F� alle de nye og sjove ikoner med MSN Messenger http://messenger.msn.dk/

No, although its declared in the Path.h file, its actually not in the
Path class. Have a look. Not sure why you're still seeing that problem.
The same change to Unix/Path.cpp fixed the same problem on Cygwin and
Linux.

Reid.

On Thu, 2004-12-23 at 15:48, Henrik Bach wrote:
> Hi Reid,
> 
> The error still exists. However, looking on the function in Win32/Path.cpp:
> --------------
> void
> sys::CopyFile(const sys::Path &Dest, const sys::Path &Src) {
>   if (!::CopyFile(Src.c_str(), Dest.c_str(), false))
>     ThrowError("Can't copy '" + Src.toString() +
>                "' to '" + Dest.toString() +
"'");
> }
> --------------
> 
> I notice, that the function is living in the sys namespace. Shouldn't
it
> live in the Path class instead? A copy-past to fast ;-)
> 
> 
> Henrik.
> 
> _________________________________________________________________
> Log på MSN Messenger direkte fra nettet  http://webmessenger.msn.com/
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20041223/3051470c/attachment.sig>

But breaks VC++.

The problem is, Windows.h defines "CopyFile" as a macro that's
either
"CopyFileA" or "CopyFileW".  Path.h is included before
Windows.h, so the
declaration has the name "CopyFile" while the definition has 
"CopyFileA".  Instant compilation error.

Not sure what the best way to fix it is, but I'll check it in as soon as 
I figure it out.

Reid Spencer wrote:
>No, although its declared in the Path.h file, its actually not in the
>Path class. Have a look. Not sure why you're still seeing that problem.
>The same change to Unix/Path.cpp fixed the same problem on Cygwin and
>Linux.
>
>Reid.
>
>On Thu, 2004-12-23 at 15:48, Henrik Bach wrote:
>  
>
>>Hi Reid,
>>
>>The error still exists. However, looking on the function in
Win32/Path.cpp:
>>--------------
>>void
>>sys::CopyFile(const sys::Path &Dest, const sys::Path &Src) {
>>  if (!::CopyFile(Src.c_str(), Dest.c_str(), false))
>>    ThrowError("Can't copy '" + Src.toString() +
>>               "' to '" + Dest.toString() +
"'");
>>}
>>--------------
>>
>>I notice, that the function is living in the sys namespace.
Shouldn't it
>>live in the Path class instead? A copy-past to fast ;-)
>>
>>
>>Henrik.
>>
>>_________________________________________________________________
>>Log på MSN Messenger direkte fra nettet  http://webmessenger.msn.com/
>>
>>_______________________________________________
>>LLVM Developers mailing list
>>LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
>>    
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>LLVM Developers mailing list
>>LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
>>    
>>