llvm dev - Jun 2004 - [LLVMdev] MachineOperand: GlobalAddress vs. ExternalSymbol

On Fri, 2004-06-18 at 10:13, Chris Lattner wrote:
> Module::gbegin/gend iterate over the global variables, and ::begin/end
> iterate over the functions, some of which may be prototypes.  
This confused Vladimir and I remember it confusing me when I was
reviewing LLVM core a few months ago. Would it be worthwhile to consider
naming these globals_begin/globals_end and
functions_begin/functions_end? so their use is completely clear?

Reid
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20040619/8cf0aa0e/attachment.sig>

On Fri, 18 Jun 2004, Reid Spencer wrote:
> On Fri, 2004-06-18 at 10:13, Chris Lattner wrote:
>
> > Module::gbegin/gend iterate over the global variables, and ::begin/end
> > iterate over the functions, some of which may be prototypes.
>
> This confused Vladimir and I remember it confusing me when I was
> reviewing LLVM core a few months ago. Would it be worthwhile to consider
> naming these globals_begin/globals_end and
> functions_begin/functions_end? so their use is completely clear?
Sure, they can be renamed.  For commonly used methods like this I would
like to keep them relatively terse though.  How about gvbegin/end and
funcbegin/end?  Would anyone like to make a patch?  :)

-Chris

-- 
http://llvm.cs.uiuc.edu/
http://www.nondot.org/~sabre/Projects/

sure, that's reasonable. I'll make the patch but later this weekend ..
bigger fish to fry :)

Reid.

On Fri, 2004-06-18 at 22:44, Chris Lattner wrote:
> On Fri, 18 Jun 2004, Reid Spencer wrote:
> > On Fri, 2004-06-18 at 10:13, Chris Lattner wrote:
> >
> > > Module::gbegin/gend iterate over the global variables, and
::begin/end
> > > iterate over the functions, some of which may be prototypes.
> >
> > This confused Vladimir and I remember it confusing me when I was
> > reviewing LLVM core a few months ago. Would it be worthwhile to
consider
> > naming these globals_begin/globals_end and
> > functions_begin/functions_end? so their use is completely clear?
> 
> Sure, they can be renamed.  For commonly used methods like this I would
> like to keep them relatively terse though.  How about gvbegin/end and
> funcbegin/end?  Would anyone like to make a patch?  :)
> 
> -Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20040619/ad613998/attachment.sig>