Linux Virtualization - May 2020 - [PATCH v3 13/75] x86/boot/compressed/64: Add IDT Infrastructure

On Tue, Apr 28, 2020 at 05:16:23PM +0200, Joerg Roedel
wrote:
> diff --git a/arch/x86/boot/compressed/idt_handlers_64.S
b/arch/x86/boot/compressed/idt_handlers_64.S
> new file mode 100644
> index 000000000000..f86ea872d860
> --- /dev/null
> +++ b/arch/x86/boot/compressed/idt_handlers_64.S
> @@ -0,0 +1,69 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Early IDT handler entry points
> + *
> + * Copyright (C) 2019 SUSE
> + *
> + * Author: Joerg Roedel <jroedel at suse.de>
> + */
> +
> +#include <asm/segment.h>
> +
> +#include "../../entry/calling.h"
Leftover from something? Commenting it out doesn't break the build here.

If needed, then we need to lift stuff in a separate header and share it
or so. I want to include as less as possible crap from kernel proper and
eventually untangle arch/x86/boot/ because include/linux/ definitions
are a real pain.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

On Mon, May 04, 2020 at 12:54:45PM +0200, Borislav Petkov
wrote:
> On Tue, Apr 28, 2020 at 05:16:23PM +0200, Joerg Roedel wrote:
> > diff --git a/arch/x86/boot/compressed/idt_handlers_64.S
b/arch/x86/boot/compressed/idt_handlers_64.S
> > new file mode 100644
> > index 000000000000..f86ea872d860
> > --- /dev/null
> > +++ b/arch/x86/boot/compressed/idt_handlers_64.S
> > @@ -0,0 +1,69 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Early IDT handler entry points
> > + *
> > + * Copyright (C) 2019 SUSE
> > + *
> > + * Author: Joerg Roedel <jroedel at suse.de>
> > + */
> > +
> > +#include <asm/segment.h>
> > +
> > +#include "../../entry/calling.h"
> 
> Leftover from something? Commenting it out doesn't break the build
here.
Yes, probably a leftover from when I tried to use the PT_REGS macros
there. I'll remove it.


Thanks,

	Joerg

On Mon, May 04, 2020 at 01:28:59PM +0200, Joerg Roedel
wrote:
> On Mon, May 04, 2020 at 12:54:45PM +0200, Borislav Petkov wrote:
> > On Tue, Apr 28, 2020 at 05:16:23PM +0200, Joerg Roedel wrote:
> > > +#include "../../entry/calling.h"
> > 
> > Leftover from something? Commenting it out doesn't break the build
here.
> 
> Yes, probably a leftover from when I tried to use the PT_REGS macros
> there. I'll remove it.
Turns out this include is still needed to get ORIG_RAX defined. I'll
leave it in place.


	Joerg