Linux Virtualization - Feb 2019 - [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()

On Thu, Jan 31, 2019 at 11:47:38AM +0100, Noralf Tr?nnes
wrote:
> 
> 
> Den 30.01.2019 10.43, skrev Gerd Hoffmann:
> > Add 3d resource parameters to virtio_gpu_object_params struct.  With
> > that in place we can use it for virtio_gpu_cmd_resource_create_3d()
> > calls.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> > ---
> 
> You don't remove the struct virtio_gpu_resource_create_3d definition,
> but it looks like there's no users left?
virtio_gpu_cmd_resource_create_3d() still uses it (and has to, it is
part of the guest <-> host protocol).

cheers,
  Gerd

Den 01.02.2019 09.01, skrev Gerd Hoffmann:
> On Thu, Jan 31, 2019 at 11:47:38AM +0100, Noralf Tr?nnes wrote:
>>
>>
>> Den 30.01.2019 10.43, skrev Gerd Hoffmann:
>>> Add 3d resource parameters to virtio_gpu_object_params struct. 
With
>>> that in place we can use it for virtio_gpu_cmd_resource_create_3d()
>>> calls.
>>>
>>> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
>>> ---
>>
>> You don't remove the struct virtio_gpu_resource_create_3d
definition,
>> but it looks like there's no users left?
> 
> virtio_gpu_cmd_resource_create_3d() still uses it (and has to, it is
> part of the guest <-> host protocol).
> 
Acked-by: Noralf Tr?nnes <noralf at tronnes.org>