Stefan Hajnoczi
2017-Nov-09 13:29 UTC
[PATCH] vhost/vsock: fix uninitialized vhost_vsock->guest_cid
The vhost_vsock->guest_cid field is uninitialized when /dev/vhost-vsock is opened until the VHOST_VSOCK_SET_GUEST_CID ioctl is called. kvmalloc(..., GFP_KERNEL | __GFP_RETRY_MAYFAIL) does not zero memory. All other vhost_vsock fields are initialized explicitly so just initialize this field too. Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/vhost/vsock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index c9de9c41aa97..5a5e981bd8e4 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsock.c @@ -518,6 +518,8 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file) goto out; } + vsock->guest_cid = 0; /* no CID assigned yet */ + atomic_set(&vsock->queued_replies, 0); vqs[VSOCK_VQ_TX] = &vsock->vqs[VSOCK_VQ_TX]; -- 2.13.6
Possibly Parallel Threads
- [PATCH] vhost/vsock: fix uninitialized vhost_vsock->guest_cid
- [PATCH 04/17] vhost: prep vhost_dev_init users to handle failures
- [PATCH v2 4/5] VSOCK: increase send pkt len in mergeable mode to improve performance
- [RFC 4/5] VSOCK: Introduce vhost-vsock.ko
- [PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko