On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote:> > > On 2017?03?30? 04:48, Michael S. Tsirkin wrote: > > We are going to add more parameters to find_vqs, let's wrap the call so > > we don't need to tweak all drivers every time. > > > > Signed-off-by: Michael S. Tsirkin<mst at redhat.com> > > --- > > A quick glance and it looks ok, but what the benefit of this series, is it > required by other changes? > > ThanksYes - to avoid touching all devices when doing the rest of the patchset.
On 2017?03?30? 22:32, Michael S. Tsirkin wrote:> On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: >> >> On 2017?03?30? 04:48, Michael S. Tsirkin wrote: >>> We are going to add more parameters to find_vqs, let's wrap the call so >>> we don't need to tweak all drivers every time. >>> >>> Signed-off-by: Michael S. Tsirkin<mst at redhat.com> >>> --- >> A quick glance and it looks ok, but what the benefit of this series, is it >> required by other changes? >> >> Thanks > Yes - to avoid touching all devices when doing the rest of > the patchset.Maybe I'm not clear. I mean the benefit of this series not this single patch. I guess it may be used by you proposal that avoid reset when set XDP? If yes, do we really want to drop some packets after XDP is set? Thanks
On Fri, Mar 31, 2017 at 12:04:55PM +0800, Jason Wang wrote:> > > On 2017?03?30? 22:32, Michael S. Tsirkin wrote: > > On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: > > > > > > On 2017?03?30? 04:48, Michael S. Tsirkin wrote: > > > > We are going to add more parameters to find_vqs, let's wrap the call so > > > > we don't need to tweak all drivers every time. > > > > > > > > Signed-off-by: Michael S. Tsirkin<mst at redhat.com> > > > > --- > > > A quick glance and it looks ok, but what the benefit of this series, is it > > > required by other changes? > > > > > > Thanks > > Yes - to avoid touching all devices when doing the rest of > > the patchset. > > Maybe I'm not clear. I mean the benefit of this series not this single > patch. I guess it may be used by you proposal that avoid reset when set XDP?In particular, yes. It generally simplifies things significantly if we can get the true buffer size back.> If yes, do we really want to drop some packets after XDP is set? > > ThanksWe would rather not drop packets. We could detect and copy them to make XDP work. -- MST