Baole Ni
2016-Aug-02 12:06 UTC
[PATCH 0992/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 669fef1..bf338d1 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -31,7 +31,7 @@ #include "vhost.h" static ushort max_mem_regions = 64; -module_param(max_mem_regions, ushort, 0444); +module_param(max_mem_regions, ushort, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_mem_regions, "Maximum number of memory regions in memory map. (default: 64)"); -- 2.9.2
Apparently Analagous Threads
- [PATCH 0992/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0753/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0753/1285] Replace numeric parameter like 0444 with macro