Linux Virtualization - Dec 2015 - [PATCH v2] vhost: replace % with & on data path

On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin
wrote:
> We know vring num is a power of 2, so use &
> to mask the high bits.
> 
> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> ---
The generated code switches from DIV -> masking, source is clearer as well.

Tested-by: Venkatesh Srinivas <venkateshs at google.com>

-- vs;

On Fri, Dec 4, 2015 at 10:19 PM, Venkatesh Srinivas
<venkateshs at google.com> wrote:
> On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote:
>> We know vring num is a power of 2, so use &
>> to mask the high bits.
>>
>> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
>> ---
>
> The generated code switches from DIV -> masking, source is clearer as
well.
First impression was why, now it seems that compiler can't predict
this for variables.
For constants it would be optimized to the same, I suppose.
>
> Tested-by: Venkatesh Srinivas <venkateshs at google.com>
>
> -- vs;
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
With Best Regards,
Andy Shevchenko