Linux Virtualization - Apr 2015 - [PATCH v2 1/6] virtio_balloon: transitional interface

On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell
wrote:
> I would leave the device *exactly* as is, ugly structure packing and
> all.
But why?  It's going to be used for years, might as well make it clean?

-- 
MST

"Michael S. Tsirkin" <mst at redhat.com>
writes:
> On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote:
>> I would leave the device *exactly* as is, ugly structure packing and
>> all.
>
> But why?  It's going to be used for years, might as well make it clean?
Because the only spec which currently exists says to do that.  We do
need a new virtio memballoon spec, but it'll look nothing like this
anyway.

Cheers,
Rusty.

On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell
wrote:
> "Michael S. Tsirkin" <mst at redhat.com> writes:
> > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote:
> >> I would leave the device *exactly* as is, ugly structure packing
and
> >> all.
> >
> > But why?  It's going to be used for years, might as well make it
clean?
> 
> Because the only spec which currently exists says to do that.
OK but the only spec which currently exists also says it's a legacy only
device, so driver must not set VERSION_1.  So surely, we can make minor
changes when VERSION_1 is set, like we did for other devices.

Let me post the latest patches I'm working on,
see what you think then.
>  We do
> need a new virtio memballoon spec, but it'll look nothing like this
> anyway.
> 
> Cheers,
> Rusty.
I think it's going to have significantly different semantics, too,
so not much value in making that one work with current
drivers, right?

-- 
MST