Joe Perches
2015-Mar-30 23:45 UTC
[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of true/false not 1/0 mips: Use bool function return values of true/false not 1/0 powerpc: Use bool function return values of true/false not 1/0 s390: Use bool function return values of true/false not 1/0 sparc: Use bool function return values of true/false not 1/0 tile: Use bool function return values of true/false not 1/0 unicore32: Use bool function return values of true/false not 1/0 x86: Use bool function return values of true/false not 1/0 virtio_console: Use bool function return values of true/false not 1/0 csiostor: Use bool function return values of true/false not 1/0 dcache: Use bool function return values of true/false not 1/0 nfsd: nfs4state: Use bool function return values of true/false not 1/0 include/linux: Use bool function return values of true/false not 1/0 sound: Use bool function return values of true/false not 1/0 rcu: tree_plugin: Use bool function return values of true/false not 1/0 sched: Use bool function return values of true/false not 1/0 ftrace: Use bool function return values of true/false not 1/0 slub: Use bool function return values of true/false not 1/0 bridge: Use bool function return values of true/false not 1/0 netfilter: Use bool function return values of true/false not 1/0 security: Use bool function return values of true/false not 1/0 sound: wm5100-tables: Use bool function return values of true/false not 1/0 arch/arm/include/asm/dma-mapping.h | 8 ++-- arch/arm/include/asm/kvm_emulate.h | 2 +- arch/arm/mach-omap2/powerdomain.c | 14 +++--- arch/arm64/include/asm/dma-mapping.h | 2 +- arch/hexagon/include/asm/dma-mapping.h | 2 +- arch/ia64/include/asm/dma-mapping.h | 2 +- arch/mips/include/asm/dma-mapping.h | 2 +- arch/powerpc/include/asm/dcr-native.h | 2 +- arch/powerpc/include/asm/dma-mapping.h | 4 +- arch/powerpc/include/asm/kvm_book3s_64.h | 4 +- arch/powerpc/sysdev/dcr.c | 2 +- arch/s390/include/asm/dma-mapping.h | 2 +- arch/sparc/mm/init_64.c | 8 ++-- arch/tile/include/asm/dma-mapping.h | 2 +- arch/unicore32/include/asm/dma-mapping.h | 2 +- arch/x86/include/asm/archrandom.h | 2 +- arch/x86/include/asm/dma-mapping.h | 2 +- arch/x86/include/asm/kvm_para.h | 2 +- arch/x86/kvm/cpuid.h | 2 +- arch/x86/kvm/vmx.c | 72 ++++++++++++++-------------- drivers/char/virtio_console.c | 2 +- drivers/scsi/csiostor/csio_scsi.c | 4 +- fs/dcache.c | 12 ++--- fs/nfsd/nfs4state.c | 2 +- include/linux/blkdev.h | 2 +- include/linux/ide.h | 2 +- include/linux/kgdb.h | 2 +- include/linux/mfd/db8500-prcmu.h | 2 +- include/linux/mm.h | 2 +- include/linux/power_supply.h | 8 ++-- include/linux/ssb/ssb_driver_extif.h | 2 +- include/linux/ssb/ssb_driver_gige.h | 16 +++---- include/sound/soc.h | 4 +- kernel/rcu/tree_plugin.h | 4 +- kernel/sched/auto_group.h | 2 +- kernel/sched/completion.c | 16 ++++--- kernel/trace/ftrace.c | 10 ++-- mm/slub.c | 12 ++--- net/bridge/br_private.h | 2 +- net/ipv4/netfilter/ipt_ah.c | 2 +- net/netfilter/ipset/ip_set_hash_ip.c | 8 ++-- net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++-- net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++-- net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++-- net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++-- net/netfilter/ipset/ip_set_hash_net.c | 8 ++-- net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++-- net/netfilter/ipset/ip_set_hash_netport.c | 8 ++-- net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++-- net/netfilter/xt_connlimit.c | 2 +- net/netfilter/xt_hashlimit.c | 2 +- net/netfilter/xt_ipcomp.c | 2 +- security/apparmor/file.c | 8 ++-- security/apparmor/policy.c | 10 ++-- sound/soc/codecs/wm5100-tables.c | 12 ++--- 55 files changed, 178 insertions(+), 176 deletions(-) -- 2.1.2
Joe Perches
2015-Mar-30 23:46 UTC
[PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0
Use the normal return values for bool functions Signed-off-by: Joe Perches <joe at perches.com> --- drivers/char/virtio_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 72d7028..50754d20 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -355,7 +355,7 @@ static inline bool use_multiport(struct ports_device *portdev) * early_init */ if (!portdev->vdev) - return 0; + return false; return __virtio_test_bit(portdev->vdev, VIRTIO_CONSOLE_F_MULTIPORT); } -- 2.1.2
Joe Perches
2015-Mar-30 23:46 UTC
[Bridge] [PATCH 22/25] bridge: Use bool function return values of true/false not 1/0
Use the normal return values for bool functions
Signed-off-by: Joe Perches <joe at perches.com>
---
net/bridge/br_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index b46fa0c..5aba35e 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -574,7 +574,7 @@ static inline void br_multicast_forward(struct
net_bridge_mdb_entry *mdst,
}
static inline bool br_multicast_is_router(struct net_bridge *br)
{
- return 0;
+ return false;
}
static inline bool br_multicast_querier_exists(struct net_bridge *br,
struct ethhdr *eth)
--
2.1.2
Casey Schaufler
2015-Mar-31 00:07 UTC
[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
On 3/30/2015 4:45 PM, Joe Perches wrote:> Joe Perches (25): > arm: Use bool function return values of true/false not 1/0 > arm64: Use bool function return values of true/false not 1/0 > hexagon: Use bool function return values of true/false not 1/0 > ia64: Use bool function return values of true/false not 1/0 > mips: Use bool function return values of true/false not 1/0 > powerpc: Use bool function return values of true/false not 1/0 > s390: Use bool function return values of true/false not 1/0 > sparc: Use bool function return values of true/false not 1/0 > tile: Use bool function return values of true/false not 1/0 > unicore32: Use bool function return values of true/false not 1/0 > x86: Use bool function return values of true/false not 1/0 > virtio_console: Use bool function return values of true/false not 1/0 > csiostor: Use bool function return values of true/false not 1/0 > dcache: Use bool function return values of true/false not 1/0 > nfsd: nfs4state: Use bool function return values of true/false not 1/0 > include/linux: Use bool function return values of true/false not 1/0 > sound: Use bool function return values of true/false not 1/0 > rcu: tree_plugin: Use bool function return values of true/false not 1/0 > sched: Use bool function return values of true/false not 1/0 > ftrace: Use bool function return values of true/false not 1/0 > slub: Use bool function return values of true/false not 1/0 > bridge: Use bool function return values of true/false not 1/0 > netfilter: Use bool function return values of true/false not 1/0 > security: Use bool function return values of true/false not 1/0 > sound: wm5100-tables: Use bool function return values of true/false not 1/0 > > arch/arm/include/asm/dma-mapping.h | 8 ++-- > arch/arm/include/asm/kvm_emulate.h | 2 +- > arch/arm/mach-omap2/powerdomain.c | 14 +++--- > arch/arm64/include/asm/dma-mapping.h | 2 +- > arch/hexagon/include/asm/dma-mapping.h | 2 +- > arch/ia64/include/asm/dma-mapping.h | 2 +- > arch/mips/include/asm/dma-mapping.h | 2 +- > arch/powerpc/include/asm/dcr-native.h | 2 +- > arch/powerpc/include/asm/dma-mapping.h | 4 +- > arch/powerpc/include/asm/kvm_book3s_64.h | 4 +- > arch/powerpc/sysdev/dcr.c | 2 +- > arch/s390/include/asm/dma-mapping.h | 2 +- > arch/sparc/mm/init_64.c | 8 ++-- > arch/tile/include/asm/dma-mapping.h | 2 +- > arch/unicore32/include/asm/dma-mapping.h | 2 +- > arch/x86/include/asm/archrandom.h | 2 +- > arch/x86/include/asm/dma-mapping.h | 2 +- > arch/x86/include/asm/kvm_para.h | 2 +- > arch/x86/kvm/cpuid.h | 2 +- > arch/x86/kvm/vmx.c | 72 ++++++++++++++-------------- > drivers/char/virtio_console.c | 2 +- > drivers/scsi/csiostor/csio_scsi.c | 4 +- > fs/dcache.c | 12 ++--- > fs/nfsd/nfs4state.c | 2 +- > include/linux/blkdev.h | 2 +- > include/linux/ide.h | 2 +- > include/linux/kgdb.h | 2 +- > include/linux/mfd/db8500-prcmu.h | 2 +- > include/linux/mm.h | 2 +- > include/linux/power_supply.h | 8 ++-- > include/linux/ssb/ssb_driver_extif.h | 2 +- > include/linux/ssb/ssb_driver_gige.h | 16 +++---- > include/sound/soc.h | 4 +- > kernel/rcu/tree_plugin.h | 4 +- > kernel/sched/auto_group.h | 2 +- > kernel/sched/completion.c | 16 ++++--- > kernel/trace/ftrace.c | 10 ++-- > mm/slub.c | 12 ++--- > net/bridge/br_private.h | 2 +- > net/ipv4/netfilter/ipt_ah.c | 2 +- > net/netfilter/ipset/ip_set_hash_ip.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_net.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_netport.c | 8 ++-- > net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++-- > net/netfilter/xt_connlimit.c | 2 +- > net/netfilter/xt_hashlimit.c | 2 +- > net/netfilter/xt_ipcomp.c | 2 +- > security/apparmor/file.c | 8 ++-- > security/apparmor/policy.c | 10 ++-- > sound/soc/codecs/wm5100-tables.c | 12 ++---Why, and why these in particular?> 55 files changed, 178 insertions(+), 176 deletions(-) >
Joe Perches
2015-Mar-31 00:14 UTC
[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote:> On 3/30/2015 4:45 PM, Joe Perches wrote: > > Joe Perches (25): > > arm: Use bool function return values of true/false not 1/0[etc...]> Why, and why these in particular?bool functions are probably better returning bool values instead of 1 and 0. Especially when the functions intermix returning returning 1/0 and true/false. (there are only a couple of those though) These are all the remaining instances in the kernel tree.
Amit Shah
2015-Mar-31 05:32 UTC
[PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0
On (Mon) 30 Mar 2015 [16:46:10], Joe Perches wrote:> Use the normal return values for bool functions > > Signed-off-by: Joe Perches <joe at perches.com> > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 72d7028..50754d20 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -355,7 +355,7 @@ static inline bool use_multiport(struct ports_device *portdev) > * early_init > */ > if (!portdev->vdev) > - return 0; > + return false;Reviewed-by: Amit Shah <amit.shah at redhat.com> Amit
Reasonably Related Threads
- [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
- [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
- [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
- [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
- [PATCH -next 000/491] treewide: use fallthrough;