On Mon, Nov 10, 2014 at 7:59 PM, Luk?? Czerner <lczerner at redhat.com> wrote:> > Hi, > > so I encountered it again on 3.17.0-rc4. This output is from the > run with your patch. > > I am using libvirt (virt-manager) to configure and run the virtual > machine, but looking at the xml, I do not think it's passing > 'scsi=off' at all. > > Btw, that xfs file system is a root file system. > > > [ 3.667553] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > [ 3.668692] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > [ 3.669897] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > [ 3.671083] blk_recount_segments: 1-0-1 vcnt-0 segs-128Hamm, I should have used bi_phys_segments to decide if merge is needed, and attached patch should fix the problem. Thanks, Ming Lei -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-block-blk-merge-fix-blk_recount_segments.patch Type: text/x-patch Size: 979 bytes Desc: not available URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20141110/d747e4cc/attachment.bin>
On Mon, 10 Nov 2014, Ming Lei wrote:> Date: Mon, 10 Nov 2014 20:18:32 +0800 > From: Ming Lei <tom.leiming at gmail.com> > To: Luk?? Czerner <lczerner at redhat.com> > Cc: Jens Axboe <axboe at kernel.dk>, > Linux Virtualization <virtualization at lists.linux-foundation.org>, > Christoph Hellwig <hch at lst.de> > Subject: Re: Re: kernel BUG at drivers/block/virtio_blk.c:172 > > On Mon, Nov 10, 2014 at 7:59 PM, Luk?? Czerner <lczerner at redhat.com> wrote: > > > > Hi, > > > > so I encountered it again on 3.17.0-rc4. This output is from the > > run with your patch. > > > > I am using libvirt (virt-manager) to configure and run the virtual > > machine, but looking at the xml, I do not think it's passing > > 'scsi=off' at all. > > > > Btw, that xfs file system is a root file system. > > > > > > [ 3.667553] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > > [ 3.668692] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > > [ 3.669897] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > > [ 3.671083] blk_recount_segments: 1-0-1 vcnt-0 segs-128 > > Hamm, I should have used bi_phys_segments to decide if > merge is needed, and attached patch should fix the problem.Thanks for the patch, unfortunately it does not fix the issue for me. I am willing to try something else though :) -Lukas> > > Thanks, > Ming Lei >
On Mon, Nov 10, 2014 at 9:05 PM, Luk?? Czerner <lczerner at redhat.com> wrote:> On Mon, 10 Nov 2014, Ming Lei wrote: > >> Date: Mon, 10 Nov 2014 20:18:32 +0800 >> From: Ming Lei <tom.leiming at gmail.com> >> To: Luk?? Czerner <lczerner at redhat.com> >> Cc: Jens Axboe <axboe at kernel.dk>, >> Linux Virtualization <virtualization at lists.linux-foundation.org>, >> Christoph Hellwig <hch at lst.de> >> Subject: Re: Re: kernel BUG at drivers/block/virtio_blk.c:172 >> >> On Mon, Nov 10, 2014 at 7:59 PM, Luk?? Czerner <lczerner at redhat.com> wrote: >> > >> > Hi, >> > >> > so I encountered it again on 3.17.0-rc4. This output is from the >> > run with your patch. >> > >> > I am using libvirt (virt-manager) to configure and run the virtual >> > machine, but looking at the xml, I do not think it's passing >> > 'scsi=off' at all. >> > >> > Btw, that xfs file system is a root file system. >> > >> > >> > [ 3.667553] blk_recount_segments: 1-0-1 vcnt-0 segs-128 >> > [ 3.668692] blk_recount_segments: 1-0-1 vcnt-0 segs-128 >> > [ 3.669897] blk_recount_segments: 1-0-1 vcnt-0 segs-128 >> > [ 3.671083] blk_recount_segments: 1-0-1 vcnt-0 segs-128 >> >> Hamm, I should have used bi_phys_segments to decide if >> merge is needed, and attached patch should fix the problem. > > Thanks for the patch, unfortunately it does not fix the issue for > me. I am willing to try something else though :)Care to post the log(like "blk_recount_segments: 1-0-1 vcnt-0 segs-128") after applying the patch in my last reply? Thanks, -- Ming Lei