On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:> From: Rusty Russell <rusty at rustcorp.com.au> > > The previous patch added one potential problem: we can still be > reading from a hwrng when it's unregistered. Add a wait for zero > in the hwrng_unregister path. > > Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>You totally corrupted Rusty's patch. If you're going to repost his series you better make sure that you've got the right patches. Just as well though as it made me think a little more about this patch :) Cheers, -- Email: Herbert Xu <herbert at gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu <herbert at gondor.apana.org.au> writes:> On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: >> From: Rusty Russell <rusty at rustcorp.com.au> >> >> The previous patch added one potential problem: we can still be >> reading from a hwrng when it's unregistered. Add a wait for zero >> in the hwrng_unregister path. >> >> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> > > You totally corrupted Rusty's patch. If you're going to repost > his series you better make sure that you've got the right patches. > > Just as well though as it made me think a little more about this > patch :)OK Amos, can you please repost the complete series? Thanks, Rusty.
On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote:> Herbert Xu <herbert at gondor.apana.org.au> writes: > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: > >> From: Rusty Russell <rusty at rustcorp.com.au> > >> > >> The previous patch added one potential problem: we can still be > >> reading from a hwrng when it's unregistered. Add a wait for zero > >> in the hwrng_unregister path. > >> > >> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> > > > > You totally corrupted Rusty's patch. If you're going to repost > > his series you better make sure that you've got the right patches. > > > > Just as well though as it made me think a little more about this > > patch :) > > OK Amos, can you please repost the complete series?Please fix the unregister race I identified first. Thanks, -- Email: Herbert Xu <herbert at gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt