Linux Virtualization - May 2013 - [PATCH] virtio-spec: tweak wording for console control vq

control vq is only used if feature bit is
negotiated - it's not enough that device supports
it. Clarify this in the spec.

Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
 virtio-spec.lyx | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 921388b..3ef96a9 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
 
 \begin_layout Description
 VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports;
configurati
-on fields nr_ports and max_nr_ports are valid and control virtqueues will
- be used.
+on fields nr_ports and max_nr_ports are valid
+\change_inserted 1986246365 1347188404
+; if this bit is negotiated,
+\change_deleted 1986246365 1347188406
+ and
+\change_unchanged
+ control virtqueues will be used.
 \change_inserted 1112500848 1368412890
 
 \end_layout
-- 
MST

"Michael S. Tsirkin" <mst at redhat.com>
writes:
> control vq is only used if feature bit is
> negotiated - it's not enough that device supports
> it. Clarify this in the spec.
Thanks, applied.

Cheers,
Rusty.
> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> ---
>  virtio-spec.lyx | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index 921388b..3ef96a9 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
>  
>  \begin_layout Description
>  VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports;
configurati
> -on fields nr_ports and max_nr_ports are valid and control virtqueues will
> - be used.
> +on fields nr_ports and max_nr_ports are valid
> +\change_inserted 1986246365 1347188404
> +; if this bit is negotiated,
> +\change_deleted 1986246365 1347188406
> + and
> +\change_unchanged
> + control virtqueues will be used.
>  \change_inserted 1112500848 1368412890
>  
>  \end_layout
> -- 
> MST