Linux Virtualization - Aug 2010 - [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

From: Haiyang Zhang <haiyangz at microsoft.com>

Subject: staging: hv: Fix missing functions for net_device_ops
  Unlike in older kernels, ether_setup() no longer sets default
functions. We need to put them into net_device_ops. For example,
eth_change_mtu prevents setting MTU beyond 1500. This is necessary
because we don't support jumbo frame at this time.
  It affects kernel 2.6.32 and later, which are all versions
containing Hyper-V drivers.

Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
Signed-off-by: Hank Janssen <hjanssen at microsoft.com>

---
 drivers/staging/hv/netvsc_drv.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 56e1157..64a0114 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -327,6 +327,9 @@ static const struct net_device_ops device_ops = {
 	.ndo_stop =			netvsc_close,
 	.ndo_start_xmit =		netvsc_start_xmit,
 	.ndo_set_multicast_list =	netvsc_set_multicast_list,
+	.ndo_change_mtu =		eth_change_mtu,
+	.ndo_validate_addr =		eth_validate_addr,
+	.ndo_set_mac_address =		eth_mac_addr,
 };
 
 static int netvsc_probe(struct device *device)
-- 
1.6.3.2

On Mon, Aug 02, 2010 at 05:46:01PM +0000, Haiyang Zhang
wrote:
> From: Haiyang Zhang <haiyangz at microsoft.com>
> 
> Subject: staging: hv: Fix missing functions for net_device_ops
>   Unlike in older kernels, ether_setup() no longer sets default
Why put the subject in the body of the email?  This forces me to edit it
again :(
> functions. We need to put them into net_device_ops. For example,
> eth_change_mtu prevents setting MTU beyond 1500. This is necessary
> because we don't support jumbo frame at this time.
What does this mean?  Is it a bug?  Just not going as fast as possible?
Something else?
>   It affects kernel 2.6.32 and later, which are all versions
> containing Hyper-V drivers.
So is this fixing a bug that needs to be backported to these older
kernels (i.e. the staging tree?)  Is this something that is causing
people problems?

Third time's a charm?

thanks,

greg k-h