Rusty Russell
2009-May-19 14:40 UTC
[PATCH] virtio_blk: add missing __dev{init,exit} markings
On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:> -static int virtblk_probe(struct virtio_device *vdev) > +static int __devinit virtblk_probe(struct virtio_device *vdev)This makes sense, I think, but then it implies that virtio_dev_probe() should also be __devinit, right? And I look at pci_bus_probe(), and it's not __devinit. Is the PCI code just slack? Rusty.
Jesse Barnes
2009-Jun-26 19:37 UTC
[PATCH] virtio_blk: add missing __dev{init,exit} markings
On Wed, 20 May 2009 00:10:51 +0930 Rusty Russell <rusty at rustcorp.com.au> wrote:> On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote: > > -static int virtblk_probe(struct virtio_device *vdev) > > +static int __devinit virtblk_probe(struct virtio_device *vdev) > > This makes sense, I think, but then it implies that > virtio_dev_probe() should also be __devinit, right? > > And I look at pci_bus_probe(), and it's not __devinit. > > Is the PCI code just slack?I wouldn't be surprised if some annotations were missing or incorrect given the churn in hotplug lately, but I can't find that particular symbol... -- Jesse Barnes, Intel Open Source Technology Center
Apparently Analagous Threads
- [PATCH] virtio_blk: add missing __dev{init,exit} markings
- [PATCH] virtio_blk: Add help function to format mass of disks
- [PATCH] virtio_blk: Add help function to format mass of disks
- [PATCH] virtio_blk: Drop unused request tracking list
- [PATCH] virtio_blk: Drop unused request tracking list