Linux Virtualization - Jan 2008 - [PATCH] virtio_rng: adopt driver to newest virtio code

Rusty,

This patch changes the virtio_rng to a callback without a return value.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

---
 drivers/char/hw_random/virtio-rng.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: kvm/drivers/char/hw_random/virtio-rng.c
==================================================================---
kvm.orig/drivers/char/hw_random/virtio-rng.c
+++ kvm/drivers/char/hw_random/virtio-rng.c
@@ -27,13 +27,12 @@ static struct virtqueue *vq;
 static u32 random_data;
 static bool have_data;
 
-static bool random_recv_done(struct virtqueue *vq)
+static void random_recv_done(struct virtqueue *vq)
 {
 	have_data = true;
 
-	/* Don't suppress callbacks: there can't be any more since we
+	/* No need to call disable_cb: there can't be any more since we
 	 * have used up the only buffer. */
-	return true;
 }
 
 static void register_buffer(void)

On Tuesday 15 January 2008 02:51:47 Christian Borntraeger
wrote:
> Rusty,
>
> This patch changes the virtio_rng to a callback without a return value.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Thanks, applied.

BTW, virtio-rng was pretty much untested, so no huge surprise it has bugs.

Rusty.