Hangbin Liu
2021-Oct-20 10:19 UTC
[Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI
On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov wrote:> Nacked-by: Nikolay Aleksandrov <nikolay at nvidia.com> > > I think we just discussed this a day ago? It is the same problem - > while we all agree the values should follow the RFC, users have had > the option to set any values forever (even non-RFC compliant ones). > This change risks breaking user-space.OK, I misunderstood your reply in last mail. I thought you only object to disabling no meaning values(e.g. set timer to 0, which not is forbid by the RFC). I don't know you also reject to follow a *MUST* rule defined in the RFC.> > Users are free to follow the RFC or not, we can't force them at this > point. This should've been done when the config option was added long > time ago.OK, I will stop working on this path. Thanks Hangbin
Hangbin Liu
2021-Oct-20 12:10 UTC
[Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI
On Wed, Oct 20, 2021 at 06:19:25PM +0800, Hangbin Liu wrote:> On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov wrote: > > Nacked-by: Nikolay Aleksandrov <nikolay at nvidia.com> > > > > I think we just discussed this a day ago? It is the same problem - > > while we all agree the values should follow the RFC, users have had > > the option to set any values forever (even non-RFC compliant ones). > > This change risks breaking user-space. > > OK, I misunderstood your reply in last mail. I thought you only object to > disabling no meaning values(e.g. set timer to 0, which not is forbid by the > RFC). I don't know you also reject to follow a *MUST* rule defined in the RFC.I know you denied the patch due to user-space compatibility. Forgive me if my last reply sound a little aggressive. Thanks Hangbin