Linux Ethernet Bridging - Oct 2021 - [Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

On 20/10/2021 05:40, Hangbin Liu wrote:
> Based on RFC3376 8.3:
> The number of seconds represented by the [Query Response Interval]
> must be less than the [Query Interval].
> 
> Fixes: d902eee43f19 ("bridge: Add multicast count/interval sysfs
entries")
> Signed-off-by: Hangbin Liu <liuhangbin at gmail.com>
> ---
>  net/bridge/br_multicast.c    | 27 +++++++++++++++++++++++++++
>  net/bridge/br_netlink.c      |  8 ++++++--
>  net/bridge/br_private.h      |  4 ++++
>  net/bridge/br_sysfs_br.c     |  6 ++----
>  net/bridge/br_vlan_options.c |  8 ++++++--
>  5 files changed, 45 insertions(+), 8 deletions(-)
> 
Nacked-by: Nikolay Aleksandrov <nikolay at nvidia.com>

I think we just discussed this a day ago? It is the same problem -
while we all agree the values should follow the RFC, users have had
the option to set any values forever (even non-RFC compliant ones).
This change risks breaking user-space.

Users are free to follow the RFC or not, we can't force them at this
point. This should've been done when the config option was added long
time ago.

Thanks,
 Nik

On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov
wrote:
> Nacked-by: Nikolay Aleksandrov <nikolay at nvidia.com>
> 
> I think we just discussed this a day ago? It is the same problem -
> while we all agree the values should follow the RFC, users have had
> the option to set any values forever (even non-RFC compliant ones).
> This change risks breaking user-space.
OK, I misunderstood your reply in last mail. I thought you only object to
disabling no meaning values(e.g. set timer to 0, which not is forbid by the
RFC). I don't know you also reject to follow a *MUST* rule defined in the
RFC.
> 
> Users are free to follow the RFC or not, we can't force them at this
> point. This should've been done when the config option was added long
> time ago.
OK, I will stop working on this path.

Thanks
Hangbin