Michael S. Tsirkin
2014-Aug-04 13:22 UTC
[Bridge] [PATCH] bridge: remove a useless comment
commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4
bridge: Dump vlan information from a bridge port
introduced a comment in an attempt to explain the
code logic. The comment is unfinished so it confuses more
than it explains, remove it.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
net/bridge/br_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 26edb51..cb5fcf6 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -208,7 +208,6 @@ int br_getlink(struct sk_buff *skb, u32 pid, u32 seq,
int err = 0;
struct net_bridge_port *port = br_port_get_rtnl(dev);
- /* not a bridge port and */
if (!port && !(filter_mask & RTEXT_FILTER_BRVLAN))
goto out;
--
MST
On Mon, 4 Aug 2014 15:22:40 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote:> commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4 > bridge: Dump vlan information from a bridge port > introduced a comment in an attempt to explain the > code logic. The comment is unfinished so it confuses more > than it explains, remove it. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Acked-by: Stephen Hemminger <stephen at networkplumber.org>
From: "Michael S. Tsirkin" <mst at redhat.com> Date: Mon, 4 Aug 2014 15:22:40 +0200> commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4 > bridge: Dump vlan information from a bridge port > introduced a comment in an attempt to explain the > code logic. The comment is unfinished so it confuses more > than it explains, remove it. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Applied, thanks.