Martin Kletzander
2017-May-24 14:11 UTC
Re: [libvirt-users] No way to stop virStream error after guest stop
On Wed, May 17, 2017 at 07:53:35PM +0000, JosÉ Luis Valencia Gutierrez wrote:>I just tried removing the callback before calling virStreamFinish and it >worked right, I thought by simply finish the stream would stop the events >and close it, the example I was based on only calls virStreamFinish on EOF >event. >I'm working on a patch that removes the callbacks after calling Finish. Our docs don't really say it's needed and I don't (yet) see the point in requiring that.
JosÉ Luis Valencia Gutierrez
2017-May-24 15:10 UTC
Re: [libvirt-users] No way to stop virStream error after guest stop
That is great, calling Abort also should remove the callbacks. On Wed, 24 May 2017 11:11 Martin Kletzander, <mkletzan@redhat.com> wrote:> On Wed, May 17, 2017 at 07:53:35PM +0000, JosÉ Luis Valencia Gutierrez > wrote: > >I just tried removing the callback before calling virStreamFinish and it > >worked right, I thought by simply finish the stream would stop the events > >and close it, the example I was based on only calls virStreamFinish on EOF > >event. > > > > I'm working on a patch that removes the callbacks after calling Finish. > Our docs don't really say it's needed and I don't (yet) see the point in > requiring that. >
Martin Kletzander
2017-Jun-02 10:33 UTC
Re: [libvirt-users] No way to stop virStream error after guest stop
On Wed, May 24, 2017 at 03:10:41PM +0000, JosÉ Luis Valencia Gutierrez wrote:>That is great, calling Abort also should remove the callbacks. >This didn't go through, I'll at least try documenting it, although that brings in a lot of other changes that should be in the documentation.>On Wed, 24 May 2017 11:11 Martin Kletzander, <mkletzan@redhat.com> wrote: > >> On Wed, May 17, 2017 at 07:53:35PM +0000, JosÉ Luis Valencia Gutierrez >> wrote: >> >I just tried removing the callback before calling virStreamFinish and it >> >worked right, I thought by simply finish the stream would stop the events >> >and close it, the example I was based on only calls virStreamFinish on EOF >> >event. >> > >> >> I'm working on a patch that removes the callbacks after calling Finish. >> Our docs don't really say it's needed and I don't (yet) see the point in >> requiring that. >>
Reasonably Related Threads
- Re: No way to stop virStream error after guest stop
- Re: No way to stop virStream error after guest stop
- Re: No way to stop virStream error after guest stop
- Re: No way to stop virStream error after guest stop
- Re: No way to stop virStream error after guest stop