search for: kletzand

On Thu, Jan 23, 2020 at 02:04:53PM +0100, Martin Kletzander wrote: > On Thu, Jan 23, 2020 at 12:16:50PM +0100, Martin Kletzander wrote: > >Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > > I forgot to mention this is trying to fix the following BZ: > > https://bugzilla.redhat.com/show_bug.cgi?id=1351000 > >---...

On Wed, Jan 29, 2020 at 03:07:12PM +0100, Martin Kletzander wrote: > From: Martin Kletzander <mkletzan@redhat.com> > > The first split does not care about the whole string, it is just trying to get > the command name in front, so triml is just right. > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > --- >...

2016-02-18 15:15 GMT+01:00 Martin Kletzander <mkletzan@redhat.com>: > On Thu, Feb 18, 2016 at 12:59:52PM +0100, John Obaterspok wrote: > >> 2016-02-18 11:25 GMT+01:00 Martin Kletzander <mkletzan@redhat.com>: >> >> On Thu, Feb 18, 2016 at 10:41:42AM +0100, John Obaterspok wrote: >>> >>>...

Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- Notes: This is the simplest solution suggested to me by Rich and it works. Most of autotools are not friends with me, so the other approach I tried, with requiring at least OCaml 4.05.0, having this fix in only for OCaml < 4.06.0 and proper...

On Fri, Nov 23, 2018 at 01:16:55PM +0000, Richard W.M. Jones wrote: >On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote: >> On Fri, Nov 23, 2018 at 11:53:05AM +0000, Richard W.M. Jones wrote: >> >On Fri, Nov 23, 2018 at 12:39:44PM +0100, Martin Kletzander wrote: >> >>There's a standardized libosinfo namespace for libvirt domain metadata. For now >> >>it supports th...

On Thu, Jan 23, 2020 at 10:32:17PM +0100, Martin Kletzander wrote: >On Thu, Jan 23, 2020 at 03:16:47PM +0000, Richard W.M. Jones wrote: >>On Thu, Jan 23, 2020 at 02:04:53PM +0100, Martin Kletzander wrote: >>> On Thu, Jan 23, 2020 at 12:16:50PM +0100, Martin Kletzander wrote: >>> >Signed-off-by: Martin Kletzander <mkletzan@...

Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- mlcustomize/customize_cmdline.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/mlcustomize/customize_cmdline.ml b/mlcustomize/customize_cmdline.ml index c062379879e2..67e85af2ad93 100644 --- a/mlcustomize/customize_cmdline.ml +++ b/mlcustomize/customize_cmdl...

My stab at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279 It took me quite some time to go through the whole rfc 4122 just to realize we do not need to do anything with the versions. Martin Kletzander (2): rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279) rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279) v2v/output_rhv_upload.ml | 10 ++++++++++ v2v/rhv-upload-plugin.py | 12 ++++++++++++ 2 files changed, 22 insertions(+) -- 2.25.0

On Wednesday, 29 January 2020 15:34:49 CET Martin Kletzander wrote: > This makes the code fail with a sensible error message instead of cryptic error > from ovirtsdk. > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > --- > v2v/rhv-upload-plugin.py | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff...

Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common b/common index c33e0036c70c..12f3fb0f6ccd 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c33e0036c70ce68d40df92e4a6c0423e136e005c +Subproject commit 12f3fb0f6ccdacb4...

SSIA Martin Kletzander (2): Don't redefine _FORTIFY_SOURCE Get rid of gnulib error bootstrap | 2 +- configure.ac | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) -- 1.8.3.2

When offset + length == exts->end the code which is shortening the extents is subtracting 0 from length. And it is not optimized out. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- server/extents.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/extents.c b/server/extents.c index d3d1a15ab97c..c422491601f0 100644 --- a/server/extents.c +++ b/server/extents.c @@ -168,7 +168,7 @@ nbdkit_add_extent (struct nbdkit_exte...

On Mon, Feb 24, 2020 at 09:51:01AM +0000, Richard W.M. Jones wrote: >On Mon, Feb 24, 2020 at 10:23:54AM +0100, Martin Kletzander wrote: >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com> >> --- >> common | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/common b/common >> index c33e0036c70c..12f3fb0f6ccd 160000 >> --- a/common >>...

...the whole rfc 4122 just to realize we do not need to do anything with the versions. v2: - Use EEXIST instead of EINVAL - Put the colliding UUID into the error - Do not evaluate the PCRE needlessly multiple times v1: https://www.redhat.com/archives/libguestfs/2020-January/msg00184.html Martin Kletzander (2): rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279) rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279) v2v/output_rhv_upload.ml | 12 ++++++++++++ v2v/rhv-upload-plugin.py | 12 ++++++++++++ 2 files changed, 24 insertions(+) -- 2.25.0

On Tue, Nov 19, 2019 at 01:48:31PM +0100, Martin Kletzander wrote: >On Tue, Nov 19, 2019 at 02:24:11PM +0200, Nir Soffer wrote: >>On Tue, Nov 19, 2019 at 2:16 PM Martin Kletzander <mkletzan@redhat.com> wrote: >>> On Tue, Nov 19, 2019 at 01:14:23PM +0200, Nir Soffer wrote: >>> >On Tue, Nov 19, 2019 at 11:17 AM Martin Kle...

I needed to compile nbdkit on CentOS 7 which is missing these protocols in curl, so hence the conditional compilation. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- I have this patch so that I can compile it on CentOS 7 (fully updated), but I'm not sure what is the support policy and I didn't even check whether the libcurl there is old or whether the SMB support is removed on purpose. plugins/curl/curl.c | 4 ++++ 1...

From: Martin Kletzander <mkletzan@redhat.com> Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- plugins/vddk/nbdkit-vddk-plugin.pod | 7 ++++++- plugins/vddk/vddk-structs.h | 1 + plugins/vddk/vddk.c | 10 ++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff...

...regexp UUID v2: - https://www.redhat.com/archives/libguestfs/2020-January/msg00221.html - Use EEXIST instead of EINVAL - Put the colliding UUID into the error - Do not evaluate the PCRE needlessly multiple times v1: https://www.redhat.com/archives/libguestfs/2020-January/msg00184.html Martin Kletzander (2): rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279) rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279) v2v/output_rhv_upload.ml | 18 ++++++++++++++++++ v2v/rhv-upload-precheck.py | 10 ++++++++++ 2 files changed, 28 insertions(+) -- 2.25...

Thanks Martin for help. I will give it a shot. Regards Rohit Singh On Thu, 6 Dec 2018 at 2:55 PM, Martin Kletzander <mkletzan@redhat.com> wrote: > On Wed, Dec 05, 2018 at 09:44:17PM +0530, ROHIT SINGH wrote: > >Hi Martin, > > > >Could you please help me with below issue, I am not sure what’s wrong > here. > >Please find below code and error snippet. > > > >Thank...

wanted to follow up on that part (thanks about all comment suggestion regarding virt-viewer and vcn, etc. I will test them as well but would prefer the 'console way' if possible On August 29, 2016 at 2:44 PM Martin Kletzander <mkletzan at redhat.com> wrote: > * When you are connected you don't see anything because the VM doesn't > have console properly set up, I'd guess. the xml file of my machines (all of them actually) have the below in the 'console' section. ? ? ... ? ? <con...