On Mon, Jul 15, 2019 at 01:27:36PM +0200, Pino Toscano
wrote:> Hi,
>
> after the latest changes, I think that the split of virt-p2v should
> be completed at this point. I have a local branch of libguestfs to
> track the removal of virt-p2v, and I do not see anything more left
> of virt-p2v after removing all the bits already converted/moved.
>
> Rich, I think it would be good for you to take a look at it, and check
> whether everything is in order e.g. for releases -- no hurry needed.
> As I do not do releases, I might have missed to copy/add something for
> them. In any case, I can do any change needed.
I think just push it. As for releases, yes we really need to have
one, but I have to fix ocaml-gettext first otherwise we can't build it
in Rawhide (I have some ocaml-gettext patches but they're not finished
yet).
> One thing about the version number: considering that virt-p2v drives
> virt-v2v based on the capabilities returned by virt-2v, I do not think
> there is a need to keep the version in sync with libguestfs.
Agreed.
> Also, considering that virt-p2v is generally stable, we can get away
> with the stable/unstable series, and just number each version as
> 1.XX.0 (so the next would be 1.41.0). The .0 as patch version is kept
> in case we need to hot-fix a version, so a .1 release can be done.
>
> What do you think?
Yes, agreed also.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html