Richard W.M. Jones
2018-Dec-01 23:09 UTC
[Libguestfs] [PATCH nbdkit] tests: Add -v (verbose) whenever we run nbdkit in test functions.
This enables debugging in the test output, and has no noticable effect (ie. all the tests still pass both without and with valgrind). Rich.
Richard W.M. Jones
2018-Dec-01 23:09 UTC
[Libguestfs] [PATCH nbdkit] tests: Add -v (verbose) whenever we run nbdkit in test functions.
Getting full output from nbdkit is worthwhile when debugging tests. --- tests/functions.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functions.sh.in b/tests/functions.sh.in index 8c65884..d647639 100644 --- a/tests/functions.sh.in +++ b/tests/functions.sh.in @@ -72,7 +72,7 @@ start_nbdkit () pidfile="$2" # Run nbdkit. - nbdkit "$@" + nbdkit -v "$@" # Wait for the pidfile to appear. for i in {1..10}; do -- 2.19.0.rc0
Eric Blake
2018-Dec-03 15:48 UTC
Re: [Libguestfs] [PATCH nbdkit] tests: Add -v (verbose) whenever we run nbdkit in test functions.
On 12/1/18 5:09 PM, Richard W.M. Jones wrote:> Getting full output from nbdkit is worthwhile when debugging tests. > --- > tests/functions.sh.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)LGTM> > diff --git a/tests/functions.sh.in b/tests/functions.sh.in > index 8c65884..d647639 100644 > --- a/tests/functions.sh.in > +++ b/tests/functions.sh.in > @@ -72,7 +72,7 @@ start_nbdkit () > pidfile="$2" > > # Run nbdkit. > - nbdkit "$@" > + nbdkit -v "$@" > > # Wait for the pidfile to appear. > for i in {1..10}; do >-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Reasonably Related Threads
- [PATCH nbdkit] tests: Add -v (verbose) whenever we run nbdkit in test functions.
- [PATCH nbdkit 0/4] tests: Move common functions into tests/functions.sh
- [PATCH v2 nbdkit 0/5] tests: Move common functions into tests/functions.sh
- Re: [PATCH nbdkit 4/4] tests: Add a helper function which waits for nbdkit to start up.
- Re: [PATCH v2 nbdkit 5/5] tests: Add a helper function which waits for nbdkit to start up.