Libguestfs - Feb 2017 - [PATCH 2/2] v2v: document Convert_linux as more generic

---
 v2v/virt-v2v.pod | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod
index 4c7204b..ba91851 100644
--- a/v2v/virt-v2v.pod
+++ b/v2v/virt-v2v.pod
@@ -227,6 +227,10 @@ And hence L<virsh(1)>, L<virt-manager(1)>, and
similar tools.
 
 =item OpenSUSE 10 and up
 
+=item Debian 6 and up
+
+=item Ubuntu 10.04, 12.04, 14.04, 16.04, and up
+
 =item Windows XP to Windows 8.1 / Windows Server 2012 R2
 
 We use Windows internal version numbers, see
@@ -758,6 +762,10 @@ below.
  
  OpenSUSE 10    kernel >= 2.6.25.5-1.1
 
+ Debian 6+      All versions support virtio
+
+ Ubuntu 10.04+  All versions support virtio
+
  Windows        Drivers are installed from the directory pointed to by
                 "VIRTIO_WIN" environment variable
                 (/usr/share/virtio-win by default) if present
@@ -792,6 +800,18 @@ RHEL 6, so you will need to update to any version
E<ge> 6.3 before
 performing the conversion.  See also
 L<https://bugzilla.redhat.com/show_bug.cgi?id=1374232>
 
+=head1 DEBIAN AND UBUNTU
+
+=head2 "warning: could not determine a way to update the configuration of
Grub2"
+
+Currently, virt-v2v has no way to set the default kernel in Debian
+and Ubuntu guests using GRUB 2 as bootloader.  This means that
+virt-v2v will not change the default kernel used for booting, even
+in case it is not the best kernel available on the guest.
+A recommended procedure is, before using virt-v2v, to check that the
+boot kernel is the best kernel available in the guest (for example
+by making sure the guest is up-to-date).
+
 =head1 WINDOWS
 
 =head2 Windows E<ge> 8 Fast Startup is incompatible with virt-v2v
-- 
2.9.3

Make the documentation in Convert_linux more generic than just
Enterprise distros using RPM.  Also, rename the name of the module from
"enterprise-linux" to simply "linux".
---
 v2v/convert_linux.ml | 10 +++++-----
 v2v/virt-v2v.pod     |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index 7d65516..05da590 100644
--- a/v2v/convert_linux.ml
+++ b/v2v/convert_linux.ml
@@ -16,12 +16,12 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  *)
 
-(* Convert various RPM-based Linux enterprise distros.  This module
- * handles:
+(* Convert various Linux distros.  This module handles:
  *
  * - RHEL and derivatives like CentOS and ScientificLinux
  * - SUSE
- * - OpenSUSE and Fedora (not enterprisey, but similar enough to RHEL/SUSE)
+ * - OpenSUSE and Fedora (similar enough to RHEL/SUSE)
+ * - Debian and derivatives like Ubuntu and Linux Mint
  *)
 
 (* < mdbooth> It's all in there for a reason :/ *)
@@ -44,7 +44,7 @@ let rec convert (g : G.guestfs) inspect source output rcaps   
* the common v2v.ml code, but that has to deal with generic guests
    * (anything common to Linux and Windows).  Here we do more detailed
    * inspection which can make the assumption that we are dealing with
-   * an Enterprise Linux guest using RPM.
+   * an Linux guest using RPM or Debian packages.
    *)
 
   (* Basic inspection data available as local variables. *)
@@ -1059,4 +1059,4 @@ let ()          i_distro = ("debian" |
"ubuntu" | "linuxmint") } -> true
     | _ -> false
   in
-  Modules_list.register_convert_module matching "enterprise-linux"
convert
+  Modules_list.register_convert_module matching "linux" convert
diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod
index ba91851..3d0eada 100644
--- a/v2v/virt-v2v.pod
+++ b/v2v/virt-v2v.pod
@@ -1910,7 +1910,7 @@ virt-v2v binary.  Typical output looks like this:
  [...]
  output:local
  [...]
- convert:enterprise-linux
+ convert:linux
  convert:windows
 
 A list of features is printed, one per line, and the program exits
-- 
2.9.3

On Fri, Feb 24, 2017 at 04:05:05PM +0100, Pino Toscano
wrote:
> ---
>  v2v/virt-v2v.pod | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod
> index 4c7204b..ba91851 100644
> --- a/v2v/virt-v2v.pod
> +++ b/v2v/virt-v2v.pod
> @@ -227,6 +227,10 @@ And hence L<virsh(1)>, L<virt-manager(1)>,
and similar tools.
>  
>  =item OpenSUSE 10 and up
>  
> +=item Debian 6 and up
> +
> +=item Ubuntu 10.04, 12.04, 14.04, 16.04, and up
> +
>  =item Windows XP to Windows 8.1 / Windows Server 2012 R2
>  
>  We use Windows internal version numbers, see
> @@ -758,6 +762,10 @@ below.
>   
>   OpenSUSE 10    kernel >= 2.6.25.5-1.1
>  
> + Debian 6+      All versions support virtio
> +
> + Ubuntu 10.04+  All versions support virtio
> +
>   Windows        Drivers are installed from the directory pointed to by
>                  "VIRTIO_WIN" environment variable
>                  (/usr/share/virtio-win by default) if present
> @@ -792,6 +800,18 @@ RHEL 6, so you will need to update to any version
E<ge> 6.3 before
>  performing the conversion.  See also
>  L<https://bugzilla.redhat.com/show_bug.cgi?id=1374232>
>  
> +=head1 DEBIAN AND UBUNTU
> +
> +=head2 "warning: could not determine a way to update the
configuration of Grub2"
> +
> +Currently, virt-v2v has no way to set the default kernel in Debian
> +and Ubuntu guests using GRUB 2 as bootloader.  This means that
> +virt-v2v will not change the default kernel used for booting, even
> +in case it is not the best kernel available on the guest.
> +A recommended procedure is, before using virt-v2v, to check that the
> +boot kernel is the best kernel available in the guest (for example
> +by making sure the guest is up-to-date).
> +
>  =head1 WINDOWS
>  
>  =head2 Windows E<ge> 8 Fast Startup is incompatible with virt-v2v
> -- 
> 2.9.3
> 
ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

On Fri, Feb 24, 2017 at 04:05:06PM +0100, Pino Toscano
wrote:
> Make the documentation in Convert_linux more generic than just
> Enterprise distros using RPM.  Also, rename the name of the module from
> "enterprise-linux" to simply "linux".
> ---
>  v2v/convert_linux.ml | 10 +++++-----
>  v2v/virt-v2v.pod     |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
> index 7d65516..05da590 100644
> --- a/v2v/convert_linux.ml
> +++ b/v2v/convert_linux.ml
> @@ -16,12 +16,12 @@
>   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   *)
>  
> -(* Convert various RPM-based Linux enterprise distros.  This module
> - * handles:
> +(* Convert various Linux distros.  This module handles:
>   *
>   * - RHEL and derivatives like CentOS and ScientificLinux
>   * - SUSE
> - * - OpenSUSE and Fedora (not enterprisey, but similar enough to
RHEL/SUSE)
> + * - OpenSUSE and Fedora (similar enough to RHEL/SUSE)
> + * - Debian and derivatives like Ubuntu and Linux Mint
>   *)
>  
>  (* < mdbooth> It's all in there for a reason :/ *)
> @@ -44,7 +44,7 @@ let rec convert (g : G.guestfs) inspect source output
rcaps >     * the common v2v.ml code, but that has to deal with generic
guests
>     * (anything common to Linux and Windows).  Here we do more detailed
>     * inspection which can make the assumption that we are dealing with
> -   * an Enterprise Linux guest using RPM.
> +   * an Linux guest using RPM or Debian packages.
"a Linux guest"
>     *)
>  
>    (* Basic inspection data available as local variables. *)
> @@ -1059,4 +1059,4 @@ let () >          i_distro = ("debian" |
"ubuntu" | "linuxmint") } -> true
>      | _ -> false
>    in
> -  Modules_list.register_convert_module matching
"enterprise-linux" convert
> +  Modules_list.register_convert_module matching "linux" convert
> diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod
> index ba91851..3d0eada 100644
> --- a/v2v/virt-v2v.pod
> +++ b/v2v/virt-v2v.pod
> @@ -1910,7 +1910,7 @@ virt-v2v binary.  Typical output looks like this:
>   [...]
>   output:local
>   [...]
> - convert:enterprise-linux
> + convert:linux
>   convert:windows
>  
>  A list of features is printed, one per line, and the program exits
> -- 
> 2.9.3
ACK with the change above.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW