Libguestfs - Jun 2015 - Re: [PATCH 3/7] daemon: Add --cmdline option for testing.

In data martedì 23 giugno 2015 23:49:51, Richard W.M. Jones ha
scritto:
> This allows the Linux kernel command line to be specified on the
> program command line.
What if, instead, we remove the direct /proc/cmdline reading from the
daemon, making the init read the options from it passing them as
options to the daemon?

After all, the options read from it so far are:
(a) guestfs_verbose
(b) guestfs_network
(c) guestfs_channel

(a) is covered already by -v, and a direct (c) could be useful to ease
this patch series (seen in patch 6).

-- 
Pino Toscano

On Wed, Jun 24, 2015 at 03:22:56PM +0200, Pino Toscano
wrote:
> In data martedì 23 giugno 2015 23:49:51, Richard W.M. Jones ha scritto:
> > This allows the Linux kernel command line to be specified on the
> > program command line.
> 
> What if, instead, we remove the direct /proc/cmdline reading from the
> daemon, making the init read the options from it passing them as
> options to the daemon?
> 
> After all, the options read from it so far are:
> (a) guestfs_verbose
> (b) guestfs_network
> (c) guestfs_channel
> 
> (a) is covered already by -v, and a direct (c) could be useful to ease
> this patch series (seen in patch 6).
Hmm parsing in shell scripts is such fun :-)

Yes this is possible.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Wed, Jun 24, 2015 at 03:52:38PM +0100, Richard W.M. Jones
wrote:
> On Wed, Jun 24, 2015 at 03:22:56PM +0200, Pino Toscano wrote:
> > In data martedì 23 giugno 2015 23:49:51, Richard W.M. Jones ha
scritto:
> > > This allows the Linux kernel command line to be specified on the
> > > program command line.
> > 
> > What if, instead, we remove the direct /proc/cmdline reading from the
> > daemon, making the init read the options from it passing them as
> > options to the daemon?
> > 
> > After all, the options read from it so far are:
> > (a) guestfs_verbose
> > (b) guestfs_network
> > (c) guestfs_channel
> > 
> > (a) is covered already by -v, and a direct (c) could be useful to ease
> > this patch series (seen in patch 6).
> 
> Hmm parsing in shell scripts is such fun :-)
> 
> Yes this is possible.
I have implemented this in v2 of the patch, coming up once I've run
through the test suite to check that nothing breaks.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top