Libguestfs - Jun 2015 - Re: [PATCH] v2v: Support loading virtio-win drivers from virtio-win.iso (RHBZ#1234351).

On Tue, Jun 23, 2015 at 09:18:01AM +0300, Shahar Havivi
wrote:
> On 22.06.15 15:33, Richard W.M. Jones wrote:
> > This makes several changes to the handling of virtio-win drivers:
> > 
> > The VIRTIO_WIN_DIR environment variable has been renamed
> > VIRTIO_WIN (but you can still use the old name).
> > 
> > You can point the VIRTIO_WIN either at a RHEL virtio-win directory
> > (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win ISO,
> > OR at the virtio-win.iso file itself.  In the latter case, libguestfs
> > is used to open the ISO file and read drivers from it.
> > 
> > The code is more flexible about the pathnames of drivers, because the
> > paths in the ISO are completely different from the paths in RHEL
> > /usr/share/virtio-win.
> Hi,
> I try to verify by setting VIRTIO_WIN to the iso and the mounted Fedora
> drivers path - in both cases I got an error that the drivers are not found.
What is the output with 'virt-v2v -v -x ...' ?
> It did work with the RHEL drivers that was in /usr/local/share/virtio-win
> as well as setting it to different location and setting the VIRTIO_WIN to
> the new location.
Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

On 23.06.15 09:04, Richard W.M. Jones wrote:
> On Tue, Jun 23, 2015 at 09:18:01AM +0300, Shahar Havivi wrote:
> > On 22.06.15 15:33, Richard W.M. Jones wrote:
> > > This makes several changes to the handling of virtio-win drivers:
> > > 
> > > The VIRTIO_WIN_DIR environment variable has been renamed
> > > VIRTIO_WIN (but you can still use the old name).
> > > 
> > > You can point the VIRTIO_WIN either at a RHEL virtio-win
directory
> > > (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win
ISO,
> > > OR at the virtio-win.iso file itself.  In the latter case,
libguestfs
> > > is used to open the ISO file and read drivers from it.
> > > 
> > > The code is more flexible about the pathnames of drivers, because
the
> > > paths in the ISO are completely different from the paths in RHEL
> > > /usr/share/virtio-win.
> > Hi,
> > I try to verify by setting VIRTIO_WIN to the iso and the mounted
Fedora
> > drivers path - in both cases I got an error that the drivers are not
found.
> 
> What is the output with 'virt-v2v -v -x ...' ?
> 
> > It did work with the RHEL drivers that was in
/usr/local/share/virtio-win
> > as well as setting it to different location and setting the VIRTIO_WIN
to
> > the new location.
attached the output
> 
> Rich.
> 
> -- 
> Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> libguestfs lets you edit virtual machines.  Supports shell scripting,
> bindings from many languages.  http://libguestfs.org

On Tue, Jun 23, 2015 at 11:34:02AM +0300, Shahar Havivi
wrote:
> attached the output
Ah ha I see:
> libguestfs: trace: find = ["vista", "vista/amd64",
"vista/amd64/netkvm.cat", "vista/amd64/netkvm.inf",
"vista/amd64/netkvm.pdb", "vista/amd64/netkvm.sys",
"vista/amd64/netkvmco.dll",
"vista/amd64/netkvmtemporarycert.cer",
"vista/amd64/readme.doc", "vista/x86",
"vista/x86/netkvm.cat", "vista/x86/netkvm.inf",
"vista/x86/netkvm.pdb", "vista/x86/netkvm.sys",
"vista/x86/netkvmco.dll",
"vista/x86/netkvmtemporarycert.cer", "vista/x86/readme.doc",
"win7", "win7/amd64", "win7/amd64/balloon.cat",
"win7/amd64/balloon.inf", "win7/amd64/balloon.pdb",
"win7/amd64/balloon.sys", "win7/amd64/blnsvr.exe",
"win7/amd64/blnsvr.pdb", "win7/amd64/netkvm.cat",
"win7/amd64/netkvm.inf", "win7/amd64/netkvm.pdb",
"win7/amd64/netkvm.sys", "win7/amd64/netkvmco.dll",
"win7/amd64/netkvmtemporarycert.cer",
"win7/amd64/readme.doc", "win7/amd64/vioscsi.cat",
"win7/amd64/vioscsi.inf", "win7/amd64/vioscsi.pdb",
"win7/amd64/vioscsi.sys", "win7/amd64/vioser-test.exe",
"win7/amd64/vioser-test.pdb", "win7/amd64/vioser.cat",
"win7/amd64/vioser.inf", "win7/amd64/vioser.pdb",
"win7/amd64/vioser.sys", "win7/amd64/viostor.cat",
"win7/amd64/viostor.inf", "win7/amd64/viostor.pdb",
"win7/amd64/viostor.sys",
"win7/amd64/wdfcoinstaller01009.dll", "win7/x86",
"win7/x86/balloon.cat", "win7/x86/balloon.inf",
"win7/x86/balloon.pdb", "win7/x86/balloon.sys",
"win7/x86/blnsvr.exe", "win7/x86/blnsvr.pdb",
"win7/x86/netkvm.cat", "win7/x86/netkvm.inf",
"win7/x86/netkvm.pdb", "win7/x86/netkvm.sys",
"win7/x86/netkvmco.dll", "win7/x86/netkvmtemporarycert.cer",
"win7/x86/readme.doc", "win7/x86/vioscsi.cat",
"win7/x86/vioscsi.inf", "win7/x86/vioscsi.pdb",
"win7/x86/vioscsi.sys", "win7/x86/vioser-test.exe",
"win7/x86/vioser-test.pdb", "win7/x86/vioser.cat",
"win7/x86/vioser.inf", "win7/x86/vioser.pdb",
"win7/x86/vioser.sys", "win7/x86/viostor.cat",
"win7/x86/viostor.inf", "win7/x86/viostor.pdb",
"win7/x86/viostor.sys", "win7/x86/wdfcoinstaller01009.dll",
[etc]
Yet another set of filename conventions ...

I think there are two things going on here, firstly more driver names
("vista"), and secondly I'm not checking names case insensitively
since my ISO has uppercased names ("Win7" vs "win7").

Anyway, easy to fix.  Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v