On Fri, Oct 10, Mike Latimer wrote:> On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: > > Thanks for the pointers. I will poke around. At least augtool on the > > host seems to behave correctly: > > I don't think this is related to Augeas. Instead, I think it's the naming > convention SUSE uses for the root btrfs subvolume (@).It does not look like its the naming convention. Insteads its the fact that a given subvolume is for the entire root filesystem. So both sda2 and also the 'whatever' subvolume get ->is_root=1. I can probably add a check somewhere to catch the whatever=="@". A better fix would be to check if a given subvolume is for the entire partition. Furthermore there are appearent bugs in the subvolume parser. Will send a patch to fix one of them shortly. Olaf
On Thu, Oct 16, Olaf Hering wrote:> I can probably add a check somewhere to catch the whatever=="@". A > better fix would be to check if a given subvolume is for the entire > partition.So after talking to David Sterba there is no way to tell if a given subvolume is for the entire partition. Also my attempt to "fix" it by using the -o option is unreliable. Richard, so what should be done with the root-partition-listed-twice issue mentioned in the URL above? Just check for a plain '@', assume thats the entire thing, and skip it to not set is_root=1? The other bug is that mounting subvolumes in such setup fails anyway because the subvol= argument lacks the absolute path. It was suggested to use the "subvolume list" option -a and tweak the resulting list. There is a <FS_TREE> prefix, which shouldnt be there according to David. Olaf
On Friday 17 October 2014 11:25:03 Olaf Hering wrote:> On Thu, Oct 16, Olaf Hering wrote: > > I can probably add a check somewhere to catch the whatever=="@". A > > better fix would be to check if a given subvolume is for the entire > > partition. > > So after talking to David Sterba there is no way to tell if a given > subvolume is for the entire partition. > Also my attempt to "fix" it by using the -o option is unreliable. > > Richard, so what should be done with the root-partition-listed-twice > issue mentioned in the URL above? Just check for a plain '@', assume > thats the entire thing, and skip it to not set is_root=1?Is '@' a particular marker for this situation? Or, from what I get, there can be any label for this?> The other bug is that mounting subvolumes in such setup fails anyway > because the subvol= argument lacks the absolute path. It was suggested > to use the "subvolume list" option -a and tweak the resulting list. > There is a <FS_TREE> prefix, which shouldnt be there according to > David.Do you have a way to reproduce the above situation (and possibly the root-partition-listed-twice situation too)? I'm not too familiar with btrfs yet, and my couple of simple installation of the latest beta of openSUSE 13.2 didn't get me that. Thanks, -- Pino Toscano