search for: sterba

A way of disabling features that are on by default in case it''s not wanted, eg. due to lack of support in the used kernel. Signed-off-by: David Sterba <dsterba@suse.cz> --- mkfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mkfs.c b/mkfs.c index cd0af9ef8b4f..f825e1b6bc2d 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1168,7 +1168,11 @@ static int parse_one_fs_feature(const char *name, u64 *flags) int found = 0; fo...

On Mon, Jun 15, 2020 at 09:57:18PM -0400, Waiman Long wrote: > In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() > was incorrectly paired with kzfree(). According to David Sterba, there > isn't any sensitive information in the subvol_info that needs to be > cleared before freeing. So kfree_sensitive() isn't really needed, > use kfree() instead. > > Reported-by: David Sterba <dsterba at suse.cz> > Signed-off-by: Waiman Long <longman at red...

...dently. The third patch contains the important bits, safety checks that the subvolumes involved in send do not accidentally lose the RO status. I haven''t seen this documented anywhere that this is mandatory, implied from how I assume send works. Please let me know if this is wrong. David Sterba (3): btrfs: send: clean up dead code btrfs: remove unused mnt from send_ctx btrfs: Check read-only status of roots during send fs/btrfs/ctree.h | 6 +++ fs/btrfs/ioctl.c | 22 +++++++++- fs/btrfs/send.c | 116 +++++++++++++++++++++++++++++------------------------- 3 files changed, 87...

...dition can be relaxed to accept also 0 which will delete unoccupied chunks and does not need space for the actual data relocation. Until there is an automatic empty chunk reclaim, we can use this as a last resort option under enospc. CC: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: David Sterba <dsterba@suse.cz> --- Also needs progs update, but is not required for the kernel side. fs/btrfs/volumes.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 5cbb7f4..fb871d0 100644 --- a/fs/btrfs/volumes.c +++ b/fs/bt...

Rename no_space_cache option to nospace_cache to be more consistent with the rest, where the simple prefix ''no'' is used to negate an option. The option has been introduced during the -rc1 cycle and there are has not been widely used, so it''s safe. Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 629281c..8bd9d6d 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -197,7 +197,7 @@ static match_table_t tokens = { {Opt_subvo...

In btrfs if we mount with "compress" we have no way to disable compressing by remounting (mount -o remount /mnt/btrfs), only by unmounting and mounting without "compress". This patch adds "nocompress" mount option which can be used to remount the filesystem without compression: # mount -o remount,nocompress /mnt/btrfs This option is usefull in cases when we have a

...4>] shrink_zones+0x90/0x254 [<0000000000213410>] do_try_to_free_pages+0xac/0x420 [<0000000000213ae0>] try_to_free_pages+0x13c/0x1b0 [<0000000000204e6c>] __alloc_pages_nodemask+0x5b4/0x9a8 [<00000000001fb04a>] grab_cache_page_write_begin+0x7e/0xe8 Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/disk-io.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index da4457f..4c86711 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -961,6 +961,13 @@ static int btree_releasepage(st...

...There is a performance penalty incured by the change, but deleting a subvolume is not a frequent operation and the tradeoff seems justified by getting the guarantee stated above. CC: Alex Lyakas <alex.btrfs@zadarastorage.com> CC: Josef Bacik <jbacik@fusionio.com> Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/ioctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index e407f75..4394632 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2268,7 +2268,7 @@ static noinline int btrfs_ioctl_snap_destroy(...

We need such a sanity check for wrong start when we defrag a file, otherwise, even with a wrong start that''s larger than file size, we can end up changing not only inode''s force compress flag but also FS''s incompat flags. Signed-off-by: Liu Bo <bo.li.liu@oracle.com> --- v2: make changelog more clearly. fs/btrfs/ioctl.c | 11 +++++++---- 1 files changed, 7

Hi, the $subj warning appears sometimes in syslog, in my case when xfstests/209 runs looped. The minimal reproducer is looped mkfs+mount. The message comes from disk-io.c btree_readpage_end_io_hook(): 581 if (check_tree_block_fsid(root, eb)) { 582 printk_ratelimited(KERN_INFO "btrfs bad fsid on block %llu\n", 583 (unsigned long

We should avoid using non multi-path (mp) path for mp disks As of now there is no good way (like api) to check that. A workaround way is to check if the O_EXCL open is unsuccessful. This is safe since otherwise the BTRFS_IOC_SCAN_DEV ioctl would fail if the disk-path can not be opened with the flag O_EXCL set. This patch also includes some (error) print format changes related to the btrfs

Hello! Long time ago I created btrfs on /dev/sda After some changes btrfs moved to /dev/sda1 (well, to md, and sda1 is part of md). As result, <btrfs fi show> show me 2 filesystems: new one and old one. Probably I need to do some cleaning. Can someone tell me what to do. fdisk -u -c -l /dev/sda Disk /dev/sda: 2000.4 GB, 2000398934016 bytes 81 heads, 63 sectors/track, 765633 cylinders,

The following case will make the incompat/compat flag of the super block be recovered. Task1 |Task2 flags = btrfs_super_incompat_flags(); | |flags = btrfs_super_incompat_flags(); flags |= new_flag1; | |flags |= new_flag2; btrfs_set_super_incompat_flags(flags); | |btrfs_set_super_incompat_flags(flags); the new_flag1 is recovered. In order to avoid this problem, we

In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() was incorrectly paired with kzfree(). According to David Sterba, there isn't any sensitive information in the subvol_info that needs to be cleared before freeing. So kfree_sensitive() isn't really needed, use kfree() instead. Reported-by: David Sterba <dsterba at suse.cz> Signed-off-by: Waiman Long <longman at redhat.com> --- fs/btrfs/ioct...

Hi, the time of temporary wiki hosted at btrfs.ipv5.de is over, the content has been migrated back to official site at http://btrfs.wiki.kernel.org (ipv5.de wiki is set to redirect there). cheers, david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at

Hi, this shown up today. I had to do a hard reboot as graceful hanged on sync(). ------------[ cut here ]------------ kernel BUG at fs/btrfs/delayed-inode.c:1466! invalid opcode: 0000 [#1] SMP CPU 10 Modules linked in: btrfs zlib_deflate lzo_compress ipmi_devintf autofs4 be2iscsi iscsi_boot_sysfs ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_addr iscsi_tcp bnx2i cnic uio ipv6 cxgb3i libcxgbi

On Fri, Oct 10, Mike Latimer wrote: > On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: > > Thanks for the pointers. I will poke around. At least augtool on the > > host seems to behave correctly: > > I don't think this is related to Augeas. Instead, I think it's the naming > convention SUSE uses for the root btrfs subvolume (@). It does not look like

...ands Chris Mason (5): btrfs-progs: fixup is_mounted checks restore: deal with holes and set i_size correctly btrfs-debug-tree: add -r option to print only the roots btrfs-progs: add a utility to corrupt a single block btrfs-progs: remove old debugging statement David Sterba (3): btrfs-progs: ignore -a option in mkfs btrfs-progs: ignore deleted loop devices btrfs-progs: pass correct build option for pthreads Goffredo Baroncelli (9): Add the --force option. mkfs.btrfs man page: document the --force option. Ignore the error ENXIO and...

...' may show up in the syslog. There''s no alternative fix in sight and the ENOSPC problem affects all 3.3 btrfs users during normal filesystem use. CC: stable@vger.kernel.org CC: Liu Bo <liubo2009@cn.fujitsu.com> CC: Chris Mason <chris.mason@oracle.com> Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/extent-tree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index a844204..ace5e8c 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4205,7 +4205,7 @@ static u64 calc...

Hi All, The official wiki seems to have lost references to "scrub" if not other commands. The last changes iss filled with account creation so I can''t see easily when that happened. Have I missed a policy change go through which is not reflected in the (Debian/Siduction) btrfs userland program yet or has something else happened? Kind regards -- To unsubscribe from this list: