Libguestfs - Sep 2013 - Re: [PATCH 3/5] sysprep: remove the custom kdump configurations

On Fri, Sep 06, 2013 at 03:52:40PM +0800, Wanlong Gao
wrote:
> +	kdump_config \
Better to call this one just "kdump" ?

However I'm unclear why anyone would want to remove kdump config in a
sysprep operation.  Or TCP wrappers for that matter.  There seems to
be no useful point in having virt-sysprep start to remove random
config files.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

On 09/06/2013 04:06 PM, Richard W.M. Jones wrote:
> On Fri, Sep 06, 2013 at 03:52:40PM +0800, Wanlong Gao wrote:
>> +	kdump_config \
> 
> Better to call this one just "kdump" ?
> 
> However I'm unclear why anyone would want to remove kdump config in a
> sysprep operation.  Or TCP wrappers for that matter.  There seems to
> be no useful point in having virt-sysprep start to remove random
> config files.
Thought that these are most important and useful config files in a VM.
Below is quoted from whom gave me these requirement:
"
Motivation
  virt-sysprep command is simple and useful command for deploying VMs.
  So, we hope its enchance.

  Though we know guestfish can be used for removing these files too,
  (by writing script, etc)
  currently it is not good for normal users by the following reasons.
   
      guestfish cannot handle errors appropriately.
        - When user uses interactive mode of guestfish, it may abort when
          error occurs.
        - When user uses batch mode of it, it may ignore error.
        - Its error message is too noisy (ex, when the specified file is not 
          present.)
"


Thanks,
Wanlong Gao
> 
> Rich.
>

On Fri, Sep 06, 2013 at 04:25:07PM +0800, Wanlong Gao
wrote:
> On 09/06/2013 04:06 PM, Richard W.M. Jones wrote:
> > On Fri, Sep 06, 2013 at 03:52:40PM +0800, Wanlong Gao wrote:
> >> +	kdump_config \
> > 
> > Better to call this one just "kdump" ?
> > 
> > However I'm unclear why anyone would want to remove kdump config
in a
> > sysprep operation.  Or TCP wrappers for that matter.  There seems to
> > be no useful point in having virt-sysprep start to remove random
> > config files.
> 
> Thought that these are most important and useful config files in a VM.
> Below is quoted from whom gave me these requirement:
> "
> Motivation
>   virt-sysprep command is simple and useful command for deploying VMs.
>   So, we hope its enchance.
> 
>   Though we know guestfish can be used for removing these files too,
>   (by writing script, etc)
>   currently it is not good for normal users by the following reasons.
>    
>       guestfish cannot handle errors appropriately.
>         - When user uses interactive mode of guestfish, it may abort when
>           error occurs.
>         - When user uses batch mode of it, it may ignore error.
>         - Its error message is too noisy (ex, when the specified file is
not
>           present.)
> "
How about the 'virt-sysprep --script' parameter?

http://libguestfs.org/virt-sysprep.1.html#script%2d

Although this uses FUSE, which is also less than ideal, it is
well-tested and the error behaviour is under user control.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v