Richard W.M. Jones
2013-Jun-05 17:05 UTC
Re: [Libguestfs] [PATCH 3/3] inspect: Partial support for non-standard windows system root
On Wed, Jun 05, 2013 at 04:56:03PM +0100, Matthew Booth wrote:> Support arbitrary windows system root for pre-vista systems where > boot.ini is on the same partition as the system root.^^^^^^^^^^^^^^^^^^^^^ I was just coming back to make this point. Is this a common configuration? All the guests I can remember have had a separate boot partition, except Windows XP. Anyway, it seems this is an improvement, and there are no obvious problems and it passes make check & make check-valgrind, so I have pushed it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Matthew Booth
2013-Jun-06 08:16 UTC
Re: [Libguestfs] [PATCH 3/3] inspect: Partial support for non-standard windows system root
On Wed, 2013-06-05 at 18:05 +0100, Richard W.M. Jones wrote:> On Wed, Jun 05, 2013 at 04:56:03PM +0100, Matthew Booth wrote: > > Support arbitrary windows system root for pre-vista systems where > > boot.ini is on the same partition as the system root. > ^^^^^^^^^^^^^^^^^^^^^ > > I was just coming back to make this point. Is this a common > configuration? All the guests I can remember have had a separate boot > partition, except Windows XP.Boot.ini only existed pre-Vista. You have to do quite a lot of work to configure a separate boot partition on a pre-Vista system, so I'm confident that this will handle the majority of practical cases. Post-Vista there's a separate boot partition, and this patch doesn't handle that. However, I haven't yet worked out if it's even possible to change the system root post-Vista.> Anyway, it seems this is an improvement, and there are no obvious > problems and it passes make check & make check-valgrind, so I have > pushed it.RHEL 6.5? Matt
Richard W.M. Jones
2013-Jun-06 08:23 UTC
Re: [Libguestfs] [PATCH 3/3] inspect: Partial support for non-standard windows system root
On Thu, Jun 06, 2013 at 09:16:05AM +0100, Matthew Booth wrote:> RHEL 6.5?Possibly. You'll have to open a bug as usual. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
Apparently Analagous Threads
- Re: [PATCH 3/3] inspect: Partial support for non-standard windows system root
- [PATCH 3/3] inspect: Partial support for non-standard windows system root
- [PATCH] inspect: Fix bogus warning for partitions without /boot.ini
- Sid MeierĀ“s Alpha Centauri
- [ANNOUNCE] libguestfs 1.16 released - tools for managing virtual machines and disk images