Richard W.M. Jones
2012-Apr-17 11:41 UTC
[Libguestfs] [libvirt] [test-API 2/3] Add the better copyright statements in scripts
On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote:> [ CC to Rich ] > > On 2012?04?17? 19:18, Osier Yang wrote: > >On 2012?04?17? 19:13, Daniel P. Berrange wrote: > >>On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: > >>>On 2012?04?17? 19:04, Daniel P. Berrange wrote: > >>>>On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: > >>>>>The new copyright statements is: > >>>>> > >>>>><copyright> > >>>>>Copyright (C) 2010-2012 Red Hat, Inc. > >>>>> > >>>>>libvirt-test-API is free software; you can redistribute it and/or > >>>>>modify it under the terms of the GNU General Public License as > >>>>>published by the Free Software Foundation, either version 2 of the > >>>>>License, or (at your option) any later version. > >>>>> > >>>>>This program is distributed in the hope that it will be useful, > >>>>>but WITHOUT ANY WARRANTY; without even the implied warranties of > >>>>>TITLE, NON-INFRINGEMENT, MERCHANTABILITY or FITNESS FOR A PARTICULAR > >>>>>PURPOSE. > >>>>> > >>>>>You should have received a copy of the GNU General Public License > >>>>>along with this program; if not, write to the Free Software > >>>>>Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > >>>>></copyright> > >>>> > >>>>I'm fairly sure that address is outdated - everywhere in libvirt > >>>>code uses > >>>> > >>>>* You should have received a copy of the GNU Lesser General Public > >>>>* License along with this library; if not, write to the Free Software > >>>>* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > >>>>02111-1307 USA > >>>> > >>> > >>>Thanks for the reminding, will post a v2, then think we need to > >>>update the address in libvirt codes too? > >> > >>Hmm, I wonder if we are better off just removing the address > >>completely. There are no end of bug reports in Fedora reviews > >>about outdated addresses and the FSF have moved locations > >>multiple times. I see GNULIB now just writes: > >> > >>* You should have received a copy of the GNU Lesser General Public > >>License > >>* along with this program. If not, see<http://www.gnu.org/licenses/>. > >> > > > >I found this when checking the GNU website mins ago. Yeah, it's better > >, per they moves from time to time, ;-) > > > > @Rich, I had to say: I copied the last 3 sentences (the address part) > from libguestfs. Perhaps it needs the updating too.They've moved again?! We are currently using: Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA and went through a big process of fixing every file to use this address a little while back. commit 04ea1375c55aa67df4e7fc61dbb534111767f3b6 Author: Matthew Booth <mbooth at redhat.com> Date: Tue Nov 8 14:27:49 2011 +0000 Update FSF address. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
Daniel P. Berrange
2012-Apr-17 11:45 UTC
[Libguestfs] [libvirt] [test-API 2/3] Add the better copyright statements in scripts
On Tue, Apr 17, 2012 at 12:41:19PM +0100, Richard W.M. Jones wrote:> On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote: > > [ CC to Rich ] > > > > On 2012?04?17? 19:18, Osier Yang wrote: > > >On 2012?04?17? 19:13, Daniel P. Berrange wrote: > > >>On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: > > >>>On 2012?04?17? 19:04, Daniel P. Berrange wrote: > > >>>>On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: > > >>>>>The new copyright statements is: > > >>>>> > > >>>>><copyright> > > >>>>>Copyright (C) 2010-2012 Red Hat, Inc. > > >>>>> > > >>>>>libvirt-test-API is free software; you can redistribute it and/or > > >>>>>modify it under the terms of the GNU General Public License as > > >>>>>published by the Free Software Foundation, either version 2 of the > > >>>>>License, or (at your option) any later version. > > >>>>> > > >>>>>This program is distributed in the hope that it will be useful, > > >>>>>but WITHOUT ANY WARRANTY; without even the implied warranties of > > >>>>>TITLE, NON-INFRINGEMENT, MERCHANTABILITY or FITNESS FOR A PARTICULAR > > >>>>>PURPOSE. > > >>>>> > > >>>>>You should have received a copy of the GNU General Public License > > >>>>>along with this program; if not, write to the Free Software > > >>>>>Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > >>>>></copyright> > > >>>> > > >>>>I'm fairly sure that address is outdated - everywhere in libvirt > > >>>>code uses > > >>>> > > >>>>* You should have received a copy of the GNU Lesser General Public > > >>>>* License along with this library; if not, write to the Free Software > > >>>>* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > > >>>>02111-1307 USA > > >>>> > > >>> > > >>>Thanks for the reminding, will post a v2, then think we need to > > >>>update the address in libvirt codes too? > > >> > > >>Hmm, I wonder if we are better off just removing the address > > >>completely. There are no end of bug reports in Fedora reviews > > >>about outdated addresses and the FSF have moved locations > > >>multiple times. I see GNULIB now just writes: > > >> > > >>* You should have received a copy of the GNU Lesser General Public > > >>License > > >>* along with this program. If not, see<http://www.gnu.org/licenses/>. > > >> > > > > > >I found this when checking the GNU website mins ago. Yeah, it's better > > >, per they moves from time to time, ;-) > > > > > > > @Rich, I had to say: I copied the last 3 sentences (the address part) > > from libguestfs. Perhaps it needs the updating too. > > They've moved again?! > > We are currently using: > > Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > Boston, MA 02110-1301 USA > > and went through a big process of fixing every file to use this > address a little while back. > > commit 04ea1375c55aa67df4e7fc61dbb534111767f3b6 > Author: Matthew Booth <mbooth at redhat.com> > Date: Tue Nov 8 14:27:49 2011 +0000 > > Update FSF address.Actually, I think it is libvirt that is at error here. The address i posted above is wrong. This all just goes to show we shouldn't include the street address at all, since no one can ever remember which one is current :-) /me will update libvirt to use the web address instead. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Osier Yang
2012-Apr-17 12:37 UTC
[Libguestfs] [libvirt] [test-API 2/3] Add the better copyright statements in scripts
On 2012?04?17? 19:41, Richard W.M. Jones wrote:> On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote: >> [ CC to Rich ] >> >> On 2012?04?17? 19:18, Osier Yang wrote: >>> On 2012?04?17? 19:13, Daniel P. Berrange wrote: >>>> On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: >>>>> On 2012?04?17? 19:04, Daniel P. Berrange wrote: >>>>>> On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: >>>>>>> The new copyright statements is: >>>>>>> >>>>>>> <copyright> >>>>>>> Copyright (C) 2010-2012 Red Hat, Inc. >>>>>>> >>>>>>> libvirt-test-API is free software; you can redistribute it and/or >>>>>>> modify it under the terms of the GNU General Public License as >>>>>>> published by the Free Software Foundation, either version 2 of the >>>>>>> License, or (at your option) any later version. >>>>>>> >>>>>>> This program is distributed in the hope that it will be useful, >>>>>>> but WITHOUT ANY WARRANTY; without even the implied warranties of >>>>>>> TITLE, NON-INFRINGEMENT, MERCHANTABILITY or FITNESS FOR A PARTICULAR >>>>>>> PURPOSE. >>>>>>> >>>>>>> You should have received a copy of the GNU General Public License >>>>>>> along with this program; if not, write to the Free Software >>>>>>> Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. >>>>>>> </copyright> >>>>>> >>>>>> I'm fairly sure that address is outdated - everywhere in libvirt >>>>>> code uses >>>>>> >>>>>> * You should have received a copy of the GNU Lesser General Public >>>>>> * License along with this library; if not, write to the Free Software >>>>>> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA >>>>>> 02111-1307 USA >>>>>> >>>>> >>>>> Thanks for the reminding, will post a v2, then think we need to >>>>> update the address in libvirt codes too? >>>> >>>> Hmm, I wonder if we are better off just removing the address >>>> completely. There are no end of bug reports in Fedora reviews >>>> about outdated addresses and the FSF have moved locations >>>> multiple times. I see GNULIB now just writes: >>>> >>>> * You should have received a copy of the GNU Lesser General Public >>>> License >>>> * along with this program. If not, see<http://www.gnu.org/licenses/>. >>>> >>> >>> I found this when checking the GNU website mins ago. Yeah, it's better >>> , per they moves from time to time, ;-) >>> >> >> @Rich, I had to say: I copied the last 3 sentences (the address part) >> from libguestfs. Perhaps it needs the updating too. > > They've moved again?! > > We are currently using: > > Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > Boston, MA 02110-1301 USA > > and went through a big process of fixing every file to use this > address a little while back. > > commit 04ea1375c55aa67df4e7fc61dbb534111767f3b6 > Author: Matthew Booth<mbooth at redhat.com> > Date: Tue Nov 8 14:27:49 2011 +0000 > > Update FSF address. > > Rich. >Ah, my libguestfs repo is *too* old, :-) Osier