Wanlong Gao
2011-Dec-23 03:46 UTC
[Libguestfs] [PATCH] extra-tests: add test-guests to prevent test error
extra-tests is depending on tests-guests.
We need guests/*.img when doing extra-tests.
/work/git/libguestfs/run valgrind
--log-file=/work/git/libguestfs/tests/extra/valgrind.log --leak-check=full
--error-exitcode=119
--suppressions=/work/git/libguestfs/tests/extra/suppressions ../../cat/virt-cat
-a ../guests/fedora.img /etc/fstab >/dev/null
../guests/fedora.img: No such file or directory
make[1]: *** [test-tools-internal] Error 1
make[1]: Leaving directory `/work/git/libguestfs/tests/extra'
Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com>
---
tests/extra/Makefile.am | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tests/extra/Makefile.am b/tests/extra/Makefile.am
index 582fa55..d129b6d 100644
--- a/tests/extra/Makefile.am
+++ b/tests/extra/Makefile.am
@@ -69,6 +69,7 @@ GUESTS = $(shell virsh -c $(LIBVIRT_DEFAULT_URI) list --all |
\
awk '{print $$2}')
extra-tests: \
+ test-guests \
test-prerequisites \
test-c-api \
test-tools-null \
@@ -80,6 +81,9 @@ extra-tests: \
test-resize \
test-sparsify
+test-guests:
+ $(MAKE) -C ../guests check
+
test-prerequisites:
@libtool --help >/dev/null 2>&1 || { \
echo "extra-tests: libtool is not installed"; \
--
1.7.8
Richard W.M. Jones
2011-Dec-23 08:31 UTC
[Libguestfs] [PATCH] extra-tests: add test-guests to prevent test error
On Fri, Dec 23, 2011 at 11:46:21AM +0800, Wanlong Gao wrote:> extra-tests is depending on tests-guests. > We need guests/*.img when doing extra-tests.Yes it is, thanks. I'll add this shortly. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
Seemingly Similar Threads
- [PATCH] build: Make valgrind tests append all output into a single log file
- [PATCH] AUTHORS: add the email address for each authors
- [PATCH 1/3] ext2: tweak the error returned message of resize2fs-M(BZ755729)
- [PATCH v2 1/3] ext2: tweak the error returned message of resize2fs-M(BZ755729)
- [PATCH] gitignore: ignore the guestfs.* directory