Libguestfs - Jun 2010 - windows v2v related patches

1.       The first (0003) is a patch I already sent it disables all vmware
tools on the windows guest.

2.       The next one (0005) is a refactoring of the code to prevent
downloading the registry hive multiple times.

3.       (0006) removes vmware run entries in the software hive.

4.       (0007) disable the parallel port driver.

5.       (0008) is reverting some of the changes in patch (0003), I'll
explain that one a bit:

I tested the v2v conversion and found that in the first run windows plug
and play doesn't find the old keyboard

and as a result it turns off the i8042prt service that is responsible for
the keyboard. This means no keyboard for 

VNC users (rdesktop users have a different keyboard mechanism that does
continue to work). As a result of this 

test, I thought that because the only service that really must be disabled
is the tool service (the one that fails  to

start and create the ugly message) We better be as little intrusive as
possible and disable the minimal set.

 

Amos.

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-removing-only-the-vmware-tools-service-do-to-bad-plu.patch
Type: application/octet-stream
Size: 1466 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-disable-vmware-tools-services.patch
Type: application/octet-stream
Size: 3148 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-download-registry-hive-once.patch
Type: application/octet-stream
Size: 5370 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-remove-vmware-run-from-registry.patch
Type: application/octet-stream
Size: 2911 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-disable-parallel-port-driver-service.patch
Type: application/octet-stream
Size: 1606 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20100607/d1963b26/attachment-0004.obj>

On Mon, Jun 07, 2010 at 04:38:25AM -0400, Amos Benari
wrote:
> 1.       The first (0003) is a patch I already sent it disables all vmware
> tools on the windows guest.
> 
> 2.       The next one (0005) is a refactoring of the code to prevent
> downloading the registry hive multiple times.
> 
> 3.       (0006) removes vmware run entries in the software hive.
> 
> 4.       (0007) disable the parallel port driver.
> 
> 5.       (0008) is reverting some of the changes in patch (0003), I'll
> explain that one a bit:
[..]

Generally ACK to all of them, looks good.

I'll let Matt have the final say.

Whitespace could do with a bit of tidying up, but maybe Matt
can do that in applying the patches.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw