Libguestfs - Dec 2009 - [PATCH] appliance: Ignore unreadable dbus helper programs.

This avoids an error where the appliance cannot start up because this
dbus helper script (which is never used) is unreadable by non-root.

Why do we have unreadable binaries in Fedora at all?  You may wonder:

https://www.redhat.com/archives/fedora-devel-list/2009-October/msg00987.html

Maintaining a blacklist like this is generally a bad thing.  We should
change this code so it automatically detects when a binary is going to
be unreadable.  However I'd like to keep an eye on this list so we
don't blacklist something which is necessary for the appliance to run.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
-------------- next part --------------
>From 795cf46a03bbe6ca0cbbeb951b8aceaf6e29eaca Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at redhat.com>
Date: Wed, 16 Dec 2009 11:04:10 +0000
Subject: [PATCH] appliance: Ignore unreadable dbus helper programs.

---
 appliance/make.sh.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/appliance/make.sh.in b/appliance/make.sh.in
index 37e1893..b3cbe92 100755
--- a/appliance/make.sh.in
+++ b/appliance/make.sh.in
@@ -96,6 +96,8 @@ if [ "@DIST@" = "REDHAT" ]; then
     /usr/sbin/groupmems \
     /sbin/unix_update \
     /usr/sbin/tcpd \
+    /lib/dbus-1/dbus-daemon-launch-helper \
+    /lib64/dbus-1/dbus-daemon-launch-helper \
     $(cd initramfs && echo usr/sbin/glibc_post_upgrade.*)
 
   # Kernel modules take up nearly half of the image.  Only include ones
-- 
1.6.5.2

On 16/12/09 11:10, Richard W.M. Jones wrote:
>
> This avoids an error where the appliance cannot start up because this
> dbus helper script (which is never used) is unreadable by non-root.
>
> Why do we have unreadable binaries in Fedora at all?  You may wonder:
>
>
https://www.redhat.com/archives/fedora-devel-list/2009-October/msg00987.html
>
> Maintaining a blacklist like this is generally a bad thing.  We should
> change this code so it automatically detects when a binary is going to
> be unreadable.  However I'd like to keep an eye on this list so we
> don't blacklist something which is necessary for the appliance to run.
>
> Rich.
>
>
>
>
> _______________________________________________
> Libguestfs mailing list
> Libguestfs at redhat.com
> https://www.redhat.com/mailman/listinfo/libguestfs
YUK (but ACK).

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490